Store coverage.info file in separate folders based on commandline parameters to coverage_posix.py.

Store coverage.info file in separate folders based on commandline parameters to coverage_posix.py.
This CL is dependent on changes in http://codereview.chromium.org/11273046

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166271

[John Grabowski, 2012-10-30 21:29:05]

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
File tools/code_coverage/coverage_posix.py (right):

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
tools/code_coverage/coverage_posix.py:765: if self.options.all_unittests:
consider an unconditional delete.  It is unclear when we'd want to delete only
one of these.

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
tools/code_coverage/coverage_posix.py:1002: if self.options.all_unittests:
make the conditional set a var called filename (either unittests_coverage or
total_coverage), then have the delete/copy/mkdir be unconditional.

[pshenoy, 2012-10-30 22:11:13]

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
File tools/code_coverage/coverage_posix.py (right):

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
tools/code_coverage/coverage_posix.py:765: if self.options.all_unittests:
On 2012/10/30 21:29:05, John Grabowski wrote:
> consider an unconditional delete.  It is unclear when we'd want to delete only
> one of these.
coverage_posix.py is run twice now. First time running all the tests and storing
the coverage.info file in "total_coverage" folder. Second time running with
"all_unittests" flag set to run only unit tests. If delete is unconditional, it
will delete the "total_coverage" before process_coverage.py is executed.

[John Grabowski, 2012-10-30 22:17:11]

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
File tools/code_coverage/coverage_posix.py (right):

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
tools/code_coverage/coverage_posix.py:765: if self.options.all_unittests:
On 2012/10/30 22:11:13, pshenoy wrote:
> On 2012/10/30 21:29:05, John Grabowski wrote:
> > consider an unconditional delete.  It is unclear when we'd want to delete
only
> > one of these.
> coverage_posix.py is run twice now. First time running all the tests and
storing
> the coverage.info file in "total_coverage" folder. Second time running with
> "all_unittests" flag set to run only unit tests. If delete is unconditional,
it
> will delete the "total_coverage" before process_coverage.py is executed.
> 

ok

[pshenoy, 2012-11-05 17:59:31]

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
File tools/code_coverage/coverage_posix.py (right):

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
tools/code_coverage/coverage_posix.py:1002: if self.options.all_unittests:
On 2012/10/30 21:29:05, John Grabowski wrote:
> make the conditional set a var called filename (either unittests_coverage or
> total_coverage), then have the delete/copy/mkdir be unconditional.
I think this is related to the other comment above in this file.

[John Grabowski, 2012-11-06 18:04:05]

LGTM but please consider pithiness.

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
File tools/code_coverage/coverage_posix.py (right):

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
tools/code_coverage/coverage_posix.py:1002: if self.options.all_unittests:
On 2012/11/05 17:59:31, pshenoy wrote:
> On 2012/10/30 21:29:05, John Grabowski wrote:
> > make the conditional set a var called filename (either unittests_coverage or
> > total_coverage), then have the delete/copy/mkdir be unconditional.
> I think this is related to the other comment above in this file. 
> 

Sort of, but it would be nice to be pithy.  For example, add a subroutine/method
called CopyCoverageFileToDestination() which is passed 'unittests_coverage' or
'total_coverage', and save a few lines of code.

[pshenoy, 2012-11-06 19:05:41]

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
File tools/code_coverage/coverage_posix.py (right):

https://codereview.chromium.org/11274053/diff/1/tools/code_coverage/coverage_...
tools/code_coverage/coverage_posix.py:1002: if self.options.all_unittests:
On 2012/11/06 18:04:05, John Grabowski wrote:
> On 2012/11/05 17:59:31, pshenoy wrote:
> > On 2012/10/30 21:29:05, John Grabowski wrote:
> > > make the conditional set a var called filename (either unittests_coverage
or
> > > total_coverage), then have the delete/copy/mkdir be unconditional.
> > I think this is related to the other comment above in this file. 
> > 
> 
> Sort of, but it would be nice to be pithy.  For example, add a
subroutine/method
> called CopyCoverageFileToDestination() which is passed 'unittests_coverage' or
> 'total_coverage', and save a few lines of code.

Done.

[commit-bot: I haz the power, 2012-11-06 19:23:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pshenoy@chromium.org/11274053/8001

[commit-bot: I haz the power, 2012-11-06 21:38:44]

Change committed as 166271