Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: content/browser/download/download_item_impl.cc

Issue 11274050: Switch CHECKS related to asserting correct state for download files in DownloadItem back to Dchecks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_item_impl.cc
diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc
index 5017ffa5111f3865909c3c16e43ce63d3ed9db6d..de2aab58d7f3487a05eea1e814a21d3e95600c57 100644
--- a/content/browser/download/download_item_impl.cc
+++ b/content/browser/download/download_item_impl.cc
@@ -1111,7 +1111,7 @@ void DownloadItemImpl::OnDownloadTargetDetermined(
// filename. Unnecessary renames may cause bugs like
// http://crbug.com/74187.
DCHECK(!is_save_package_download_);
- CHECK(download_file_.get());
+ DCHECK(download_file_.get());
DownloadFile::RenameCompletionCallback callback =
base::Bind(&DownloadItemImpl::OnDownloadRenamedToIntermediateName,
weak_ptr_factory_.GetWeakPtr());
@@ -1200,7 +1200,7 @@ void DownloadItemImpl::ReadyForDownloadCompletionDone() {
return;
}
- CHECK(download_file_.get());
+ DCHECK(download_file_.get());
if (NeedsRename()) {
content::DownloadFile::RenameCompletionCallback callback =
base::Bind(&DownloadItemImpl::OnDownloadRenamedToFinalName,
@@ -1249,7 +1249,7 @@ void DownloadItemImpl::OnDownloadRenamedToFinalName(
void DownloadItemImpl::ReleaseDownloadFile() {
// Complete the download and release the DownloadFile.
DCHECK(!is_save_package_download_);
- CHECK(download_file_.get());
+ DCHECK(download_file_.get());
BrowserThread::PostTask(
BrowserThread::FILE, FROM_HERE,
base::Bind(&DownloadFileDetach, base::Passed(download_file_.Pass()),
@@ -1308,7 +1308,7 @@ void DownloadItemImpl::CancelDownloadFile() {
// TODO(rdsmith/benjhayden): Remove condition as part of
// SavePackage integration.
if (!is_save_package_download_) {
- CHECK(download_file_.get());
+ DCHECK(download_file_.get());
BrowserThread::PostTask(
BrowserThread::FILE, FROM_HERE,
// Will be deleted at end of task execution.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698