Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 11274037: Improve the test. (Closed)

Created:
8 years, 1 month ago by Siva Chandra
Modified:
8 years, 1 month ago
Reviewers:
cmp, Isaac (away)
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tests/gclient_test.py View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Siva Chandra
Improve the test per ilevy's suggestion.
8 years, 1 month ago (2012-10-25 00:23:26 UTC) #1
Isaac (away)
lgtm, waiting for cmp approval
8 years, 1 month ago (2012-10-25 00:26:30 UTC) #2
Isaac (away)
8 years, 1 month ago (2012-10-25 00:26:44 UTC) #3
Siva Chandra
+cmp as reviewer for OWNER lgtm.
8 years, 1 month ago (2012-10-25 00:26:48 UTC) #4
cmp
lgtm
8 years, 1 month ago (2012-10-25 00:33:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/11274037/1
8 years, 1 month ago (2012-10-25 00:47:24 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 00:50:11 UTC) #7
Change committed as 163975

Powered by Google App Engine
This is Rietveld 408576698