Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11274003: webkit: Merge 'database' and 'quota' to 'webkit_storage' (Closed)

Created:
8 years, 2 months ago by hashimoto
Modified:
8 years, 1 month ago
Reviewers:
kinuko, michaeln, jam
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

webkit: Merge 'database' and 'quota' to 'webkit_storage' Remove webkit/database/quota_table* since it's not used. Merge 'database' and 'quota' to 'webkit_storage'. Add WEBKIT_STORAGE_EXPORT(_PRIVATE) when necessary. BUG=155242 TEST=build TBR=jam@chromium.org for trivial gyp changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164329

Patch Set 1 : _ #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : Fix win export problem #

Patch Set 5 : Add a friend declaration #

Patch Set 6 : More EXPORT for Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -277 lines) Patch
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/content_common.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 3 chunks +1 line, -3 lines 0 comments Download
M webkit/database/database_connections.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/database/database_quota_client.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/database/database_tracker.h View 3 chunks +6 lines, -4 lines 0 comments Download
M webkit/database/database_util.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/database/databases_table.h View 3 chunks +3 lines, -2 lines 0 comments Download
D webkit/database/quota_table.h View 1 chunk +0 lines, -31 lines 0 comments Download
D webkit/database/quota_table.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webkit/database/quota_table_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M webkit/database/vfs_backend.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/database/webkit_database.gypi View 1 chunk +16 lines, -37 lines 0 comments Download
M webkit/quota/quota_client.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M webkit/quota/quota_database.h View 1 2 3 4 5 5 chunks +8 lines, -7 lines 0 comments Download
M webkit/quota/quota_manager.h View 1 2 3 4 5 chunks +8 lines, -6 lines 0 comments Download
M webkit/quota/quota_task.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/quota/quota_temporary_storage_evictor.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/quota/special_storage_policy.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/quota/webkit_quota.gypi View 1 chunk +18 lines, -36 lines 0 comments Download
M webkit/storage/webkit_storage.gypi View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
hashimoto
kinuko@: Please review webkit/quota michaeln@: Please review webkit/database
8 years, 2 months ago (2012-10-24 07:36:33 UTC) #1
kinuko
webkit/quota lgtm
8 years, 2 months ago (2012-10-24 09:56:54 UTC) #2
michaeln
lgtm2
8 years, 2 months ago (2012-10-24 16:26:21 UTC) #3
hashimoto
TBR-ing jam@ for trivial gyp changes
8 years, 1 month ago (2012-10-25 03:18:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11274003/12002
8 years, 1 month ago (2012-10-25 03:18:28 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-10-25 11:39:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11274003/12002
8 years, 1 month ago (2012-10-25 11:46:22 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-10-25 12:16:19 UTC) #8
jam
lgtm
8 years, 1 month ago (2012-10-25 16:15:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11274003/4004
8 years, 1 month ago (2012-10-26 02:31:59 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-10-26 03:22:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11274003/4006
8 years, 1 month ago (2012-10-26 06:47:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/11274003/18008
8 years, 1 month ago (2012-10-26 08:07:09 UTC) #13
commit-bot: I haz the power
8 years, 1 month ago (2012-10-26 13:13:55 UTC) #14 
Change committed as 164329

Powered by Google App Engine
This is Rietveld 408576698