Issue 11274002: Fix pexpect import in android_commands.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11274002: Fix pexpect import in android_commands.py (Closed)

Created:
8 years, 2 months ago by Isaac (away)

Modified:
8 years, 2 months ago

Reviewers:

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, nduca

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix pexpect import in android_commands.py The "from pylib" import assumed cwd was build/android, which is not always the case. BUG=154343 TBR=bulach NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163783

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/android/pylib/android_commands.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11274002/1

8 years, 2 months ago (2012-10-24 06:22:00 UTC) #2

tonyg

8 years, 2 months ago (2012-10-24 15:34:54 UTC) #4

This change broke Chrome Remote Control again:
http://build.chromium.org/p/chromium.perf/builders/Win7%20GPU%20%28ATI%29%20P...

It is now importing the third_party pexpect directly without the pylib
pexpect.py wrapper that has the try-except. I'm going to just put the try-except
back into android_commands.py.

Expand Messages | Collapse Messages