Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 11273033: Implement Chrome Extension TabCapture API (Closed)

Created:
8 years, 1 month ago by justinlin
Modified:
8 years, 1 month ago
Reviewers:
wjia(left Chromium), sky, aa
CC:
chromium-reviews, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, hclam, miu, mark a. foltz
Visibility:
Public.

Description

Implement chrome extension tab capture API as specified here: http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/webrtc-tab-content-capture Also, make tab capture media stream requests verify that the request came from extension API. BUG=153388 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164230

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Patch issue 11198044 #

Patch Set 4 : Fix proxy object leak #

Patch Set 5 : Lazy init registry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1091 lines, -35 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +15 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/tab_capture/tab_capture_api.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 chunk +158 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/tab_capture/tab_capture_registry.h View 1 2 3 1 chunk +98 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 1 chunk +189 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/tab_capture/tab_capture_registry_factory.h View 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/tab_capture/tab_capture_registry_factory.cc View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 2 3 chunks +4 lines, -25 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/tab_capture.idl View 1 chunk +62 lines, -0 lines 0 comments Download
M chrome/common/extensions/feature_switch.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/feature_switch.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/request_media_access_permission_helper.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/common/extensions/request_media_access_permission_helper.cc View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/renderer/resources/extensions/tab_capture_custom_bindings.js View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tab_capture/experimental/manifest.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tab_capture/experimental/test.js View 1 chunk +117 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tab_capture/permissions/manifest.json View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tab_capture/permissions/test.js View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
justinlin
Hi, I landed this Today, but I had to revert it due to valgrind picking ...
8 years, 1 month ago (2012-10-25 06:14:31 UTC) #1
sky
LGTM
8 years, 1 month ago (2012-10-25 16:04:44 UTC) #2
wjia(left Chromium)
lgtm on media stream.
8 years, 1 month ago (2012-10-25 16:52:05 UTC) #3
Aaron Boodman
lgtm
8 years, 1 month ago (2012-10-25 18:34:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11273033/10007
8 years, 1 month ago (2012-10-25 20:18:36 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-26 00:58:19 UTC) #6
Change committed as 164230

Powered by Google App Engine
This is Rietveld 408576698