Remove the managed banner from the Chrome settings UI

chrome/browser/resources/options/options_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /////////////////////////////////////////////////////////////////////////////
   // OptionsPage class:
 
   /**
    * Base class for options page.
@@ skipping 400 matching lines @@
 
   /**
    * Hides the currently visible bubble, if any.
    */
   OptionsPage.hideBubble = function() {
     if (OptionsPage.bubble_)
       OptionsPage.bubble_.hide();
   };
 
   /**
-   * Updates managed banner visibility state based on the topmost page.
-   */
-  OptionsPage.updateManagedBannerVisibility = function() {
-    var topPage = this.getTopmostVisiblePage();
-    if (topPage)
-      topPage.updateManagedBannerVisibility();
-  };
-
-  /**
    * Shows the tab contents for the given navigation tab.
    * @param {!Element} tab The tab that the user clicked.
    */
   OptionsPage.showTab = function(tab) {
     // Search parents until we find a tab, or the nav bar itself. This allows
     // tabs to have child nodes, e.g. labels in separately-styled spans.
     while (tab && !tab.classList.contains('subpages-nav-tabs') &&
            !tab.classList.contains('tab')) {
       tab = tab.parentNode;
     }
@@ skipping 268 matching lines @@
      * @type {OptionsPage}
      */
     associatedControls: null,
 
     /**
      * Initializes page content.
      */
     initializePage: function() {},
 
     /**
-     * Updates managed banner visibility state. This function iterates over
-     * all input fields of a page and if any of these is marked as managed
-     * it triggers the managed banner to be visible. The banner can be enforced
-     * being on through the managed flag of this class but it can not be forced
-     * being off if managed items exist.
-     */
-    updateManagedBannerVisibility: function() {
-      var bannerDiv = this.pageDiv.querySelector('.managed-prefs-banner');
-      // Create a banner for the overlay if we don't have one.
-      if (!bannerDiv) {
-        bannerDiv = $('managed-prefs-banner').cloneNode(true);
-        bannerDiv.id = null;
-
-        if (this.isOverlay) {
-          var content = this.pageDiv.querySelector('.content-area');
-          content.parentElement.insertBefore(bannerDiv, content);
-        } else {
-          bannerDiv.classList.add('main-page-banner');
-          var header = this.pageDiv.querySelector('header');
-          header.appendChild(bannerDiv);
-        }
-      }
-
-      var controlledByPolicy = false;
-      var controlledByExtension = false;
-      var inputElements = this.pageDiv.querySelectorAll('input[controlled-by]');
-      for (var i = 0; i < inputElements.length; i++) {
-        if (inputElements[i].controlledBy == 'policy')
-          controlledByPolicy = true;
-        else if (inputElements[i].controlledBy == 'extension')
-          controlledByExtension = true;
-      }
-
-      if (!controlledByPolicy && !controlledByExtension) {
-        this.pageDiv.classList.remove('showing-banner');
-      } else {
-        this.pageDiv.classList.add('showing-banner');
-
-        var text = bannerDiv.querySelector('#managed-prefs-text');

[Joao da Silva, 2012/10/25 11:07:52]

An element with id 'managed-prefs-text' exists in
chrome/browser/resources/extensions/extensions.html. Can this code really be
removed?

That element seems related to managed mode, maybe Bernhard knows more about
this.

[bartfab (slow), 2012/10/25 13:13:13]

The managed mode banner actually has a completely independent implementation and
only shared CSS with the options banners. I left the CSS intact, so that banner
is still working (I verified it just in case).

The managed mode banner did have some stale ids/classes that nothing in CSS, JS
or C++ ever referenced. I removed those now.

-        if (controlledByPolicy && !controlledByExtension) {
-          text.textContent =
-              loadTimeData.getString('policyManagedPrefsBannerText');
-        } else if (!controlledByPolicy && controlledByExtension) {
-          text.textContent =
-              loadTimeData.getString('extensionManagedPrefsBannerText');
-        } else if (controlledByPolicy && controlledByExtension) {
-          text.textContent = loadTimeData.getString(
-              'policyAndExtensionManagedPrefsBannerText');
-        }
-      }
-    },
-
-    /**
      * Gets the container div for this page if it is an overlay.
      * @type {HTMLElement}
      */
     get container() {
       assert(this.isOverlay);
       return this.pageDiv.parentNode;
     },
 
     /**
      * Gets page visibility state.
@@ skipping 104 matching lines @@
       }
     },
 
     /**
      * Called when a page is shown or hidden to update the root options page
      * based on this page's visibility.
      * @private
      */
     onVisibilityChanged_: function() {
       OptionsPage.updateRootPageFreezeState();
-      OptionsPage.updateManagedBannerVisibility();
 
       if (this.isOverlay && !this.visible)
         OptionsPage.updateScrollPosition_();
     },
 
     /**
      * The nesting level of this page.
      * @type {number} The nesting level of this page (0 for top-level page)
      */
     get nestingLevel() {
@@ skipping 38 matching lines @@
     canShowPage: function() {
       return true;
     },
   };
 
   // Export
   return {
     OptionsPage: OptionsPage
   };
 });