chrome/browser/ui/views/frame/browser_view.h - Issue 11272015: DevTools: “Dock to right” broken after turning a tab into a window of its own.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 11272015: DevTools: “Dock to right” broken after turning a tab into a window of its own. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/debugger/devtools_window.cc ('K') | « chrome/browser/ui/gtk/browser_window_gtk.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index c5905c846f67457d5a37ffa38774fdc41db68854..9f02630a14bc82b94921bad1bfdec22e96074ea4 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -499,17 +499,17 @@ class BrowserView : public BrowserWindow,

// |contents| can be NULL.

bool MaybeShowInfoBar(TabContents* contents);

+ // Updated devtools window for given contents.

Peter Kasting 2012/10/24 21:18:09 Nit: Updated -> Update? What does "Update dev too

pfeldman 2012/10/25 15:17:40 Done. Added comment.

+ void UpdateDevToolsForContents(TabContents* tab_contents);

// Shows docked devtools.

- void ShowDevToolsContainer(DevToolsDockSide side);

+ void ShowDevToolsContainer();

// Hides docked devtools.

void HideDevToolsContainer();

- // Updates devtools dock side.

- void SetDevToolsDockSide(DevToolsDockSide side);

- // Updated devtools window for given contents.

- void UpdateDevToolsForContents(TabContents* tab_contents);

+ // Updates docked devtools size.

Peter Kasting 2012/10/24 21:18:09 Nit: Again, "updates" is too vague. What does thi

pfeldman 2012/10/25 15:17:40 Done.

+ void UpdateDevToolsSplitPosition();

// Updates various optional child Views, e.g. Bookmarks Bar, Info Bar or the

// Download Shelf in response to a change notification from the specified

@@ -659,9 +659,12 @@ class BrowserView : public BrowserWindow,

// Split view containing the contents container and devtools container.

views::SingleSplitView* contents_split_;

- // Side to dock devtools to

+ // Side to dock devtools to.

DevToolsDockSide devtools_dock_side_;

+ // Docked devtools window instance.

Peter Kasting 2012/10/24 21:18:09 Can this be NULL?

pfeldman 2012/10/25 15:17:40 Done.

+ DevToolsWindow* devtools_window_;

// Tracks and stores the last focused view which is not the

// devtools_container_ or any of its children. Used to restore focus once

// the devtools_container_ is hidden.