Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: chrome/browser/ui/cocoa/dev_tools_controller.h

Issue 11272015: DevTools: “Dock to right” broken after turning a tab into a window of its own. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: GTK comments addressed, docs updated. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_DEV_TOOLS_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_DEV_TOOLS_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_COCOA_DEV_TOOLS_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_COCOA_DEV_TOOLS_CONTROLLER_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include "base/memory/scoped_nsobject.h" 10 #include "base/memory/scoped_nsobject.h"
(...skipping 10 matching lines...) Expand all
21 21
22 // A class that handles updates of the devTools view within a browser window. 22 // A class that handles updates of the devTools view within a browser window.
23 // It swaps in the relevant devTools contents for a given WebContents or removes 23 // It swaps in the relevant devTools contents for a given WebContents or removes
24 // the view, if there's no devTools contents to show. 24 // the view, if there's no devTools contents to show.
25 @interface DevToolsController : NSObject<NSSplitViewDelegate> { 25 @interface DevToolsController : NSObject<NSSplitViewDelegate> {
26 @private 26 @private
27 // A view hosting docked devTools contents. 27 // A view hosting docked devTools contents.
28 scoped_nsobject<NSSplitView> splitView_; 28 scoped_nsobject<NSSplitView> splitView_;
29 29
30 DevToolsDockSide dockSide_; 30 DevToolsDockSide dockSide_;
31
32 // Docked devtools window instance. NULL when current tab is not inspected
33 // or is inspected with undocked version of DevToolsWindow.
34 DevToolsWindow* devToolsWindow_;
31 } 35 }
32 36
33 - (id)init; 37 - (id)init;
34 38
35 // This controller's view. 39 // This controller's view.
36 - (NSView*)view; 40 - (NSView*)view;
37 41
38 // The compiler seems to have trouble handling a function named "view" that 42 // The compiler seems to have trouble handling a function named "view" that
39 // returns an NSSplitView, so provide a differently-named method. 43 // returns an NSSplitView, so provide a differently-named method.
40 - (NSSplitView*)splitView; 44 - (NSSplitView*)splitView;
41 45
42 // Depending on |contents|'s state, decides whether the docked web inspector 46 // Depending on |contents|'s state, decides whether the docked web inspector
43 // should be shown or hidden and adjusts its height (|delegate_| handles 47 // should be shown or hidden and adjusts its height (|delegate_| handles
44 // the actual resize). 48 // the actual resize).
45 - (void)updateDevToolsForWebContents:(content::WebContents*)contents 49 - (void)updateDevToolsForWebContents:(content::WebContents*)contents
46 withProfile:(Profile*)profile; 50 withProfile:(Profile*)profile;
47 @end 51 @end
48 52
49 #endif // CHROME_BROWSER_UI_COCOA_DEV_TOOLS_CONTROLLER_H_ 53 #endif // CHROME_BROWSER_UI_COCOA_DEV_TOOLS_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698