Add gclient grep for git repos

Add gclient grep for git repos

- Adds a gclient grep command to search through git repos.
- Not done: print the cwd for each dep that has output.

R=maruel@chromium.org
BUG=157950

[M-A Ruel, 2012-10-26 12:45:42]

I think a gclient fetch would be nice too.

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py
File gclient.py (right):

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1252
gclient.py:1252: 
2 lines

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1260
gclient.py:1260: parser.set_defaults(jobs=1)
I think it'd be preferable to remove the option with
parser.remove_option('--jobs')

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1265
gclient.py:1265: args = ['-j%d' % options.jobs, '-i', '-s', 'git', 'git',
'grep',
'-jobs', '1', '--ignore', '--scm', 'git', ...
Can you use the long argument names instead? This makes the command line clearer
when reading the code.

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1590
gclient.py:1590: 'default=%default')
Don't change here.

[Isaac (away), 2012-11-05 07:08:48]

>> I think a gclient fetch would be nice too.

This is already done - see CMDfetch above.


Any suggestions for prepending the submodule path to git grep output?  Otherwise
the file paths are hard to decipher.

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py
File gclient.py (right):

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1252
gclient.py:1252: 
On 2012/10/26 12:45:42, Marc-Antoine Ruel wrote:
> 2 lines

Done.

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1260
gclient.py:1260: parser.set_defaults(jobs=1)
On 2012/10/26 12:45:42, Marc-Antoine Ruel wrote:
> I think it'd be preferable to remove the option with
> parser.remove_option('--jobs')

I'd like to leave this option available in some form.  -j=<high> is useful if
one isn't expecting a lot of matches.  I re-wrote the parsing code in the latest
patch.

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1265
gclient.py:1265: args = ['-j%d' % options.jobs, '-i', '-s', 'git', 'git',
'grep',
On 2012/10/26 12:45:42, Marc-Antoine Ruel wrote:
> '-jobs', '1', '--ignore', '--scm', 'git', ...
> Can you use the long argument names instead? This makes the command line
clearer
> when reading the code.

Done.  I was copying CMDfetch from above.  I've updated that one too.

https://chromiumcodereview.appspot.com/11270056/diff/1/gclient.py#newcode1590
gclient.py:1590: 'default=%default')
On 2012/10/26 12:45:42, Marc-Antoine Ruel wrote:
> Don't change here.

Done.

[M-A Ruel, 2012-11-05 13:51:14]

On 2012/11/05 07:08:48, Isaac wrote:
> >> I think a gclient fetch would be nice too.
> 
> This is already done - see CMDfetch above.

Ahah I'm silly.

Please switch back to using optparse

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py
File gclient.py (right):

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1277
gclient.py:1277: # We can't use optparse because it will try to parse arguments
sent
You can, you need to use parser.disable_interspersed_args()

[Isaac (away), 2012-11-05 17:09:53]

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py
File gclient.py (right):

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1277
gclient.py:1277: # We can't use optparse because it will try to parse arguments
sent
On 2012/11/05 13:51:14, Marc-Antoine Ruel wrote:
> You can, you need to use parser.disable_interspersed_args()

That does not allow users to pass arguments to git grep. 
i.e. gclient grep -i foo to call git grep with -i.

[M-A Ruel, 2012-11-05 17:39:05]

lgtm with the proper Usage print.

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py
File gclient.py (right):

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1274
gclient.py:1274: print 'Usage [-j <N>] git-grep args...'
print >> sys.stderr, 'Usage: git cl grep [-j <N>] <git-grep args>...'
or:
parser.remove('--help')
parser.help()

but I'm not sure it'd work properly either. So I'm fine with just printing usage
to stderr.

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1277
gclient.py:1277: # We can't use optparse because it will try to parse arguments
sent
On 2012/11/05 17:09:53, Isaac wrote:
> On 2012/11/05 13:51:14, Marc-Antoine Ruel wrote:
> > You can, you need to use parser.disable_interspersed_args()
> 
> That does not allow users to pass arguments to git grep. 
> i.e. gclient grep -i foo to call git grep with -i. 

Ok, I always used -- naturally but I agree it's user hostile.

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1285
gclient.py:1285: 
You also lose support for -h and --help. But it's not much a big deal.

[Isaac (away), 2012-11-07 07:13:53]

There's an issue with base url here (I uploaded from non git-svn).  So
abandoning this CL and moving to
https://chromiumcodereview.appspot.com/11312116/

Please put new comments on the other CL.

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py
File gclient.py (right):

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1274
gclient.py:1274: print 'Usage [-j <N>] git-grep args...'
On 2012/11/05 17:39:05, Marc-Antoine Ruel wrote:
> print >> sys.stderr, 'Usage: git cl grep [-j <N>] <git-grep args>...'
> or:
> parser.remove('--help')
> parser.help()
> 
> but I'm not sure it'd work properly either. So I'm fine with just printing
usage
> to stderr.

Done.

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1277
gclient.py:1277: # We can't use optparse because it will try to parse arguments
sent
On 2012/11/05 17:39:05, Marc-Antoine Ruel wrote:
> On 2012/11/05 17:09:53, Isaac wrote:
> > On 2012/11/05 13:51:14, Marc-Antoine Ruel wrote:
> > > You can, you need to use parser.disable_interspersed_args()
> > 
> > That does not allow users to pass arguments to git grep. 
> > i.e. gclient grep -i foo to call git grep with -i. 
> 
> Ok, I always used -- naturally but I agree it's user hostile.

SG.  Some git commands also use -- so prefer not to confuse people.

https://chromiumcodereview.appspot.com/11270056/diff/5001/gclient.py#newcode1285
gclient.py:1285: 
On 2012/11/05 17:39:05, Marc-Antoine Ruel wrote:
> You also lose support for -h and --help. But it's not much a big deal.

I fixed this w/ a regex -- see new review.