Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 11270022: Handle OnBoundsChanged for fullscreen RWHV because it dosen't have WebContentsViewAura that calls S… (Closed)

Created:
8 years, 2 months ago by oshima
Modified:
8 years, 1 month ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, ilja
Visibility:
Public.

Description

Handle OnBoundsChanged for fullscreen RWHV because it dosen't have WebContentsViewAura that calls SetSize BUG=chrome-os-partner:13073 TEST=manual: see bug for repro step. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164146

Patch Set 1 : #

Total comments: 2

Patch Set 2 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
I'm not 100% sure if this is the right fix. Please let me know if ...
8 years, 2 months ago (2012-10-25 00:20:22 UTC) #1
oshima
8 years, 2 months ago (2012-10-25 00:20:40 UTC) #2
Ben Goodger (Google)
lgtm looks ok http://codereview.chromium.org/11270022/diff/4001/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): http://codereview.chromium.org/11270022/diff/4001/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1281 content/browser/renderer_host/render_widget_host_view_aura.cc:1281: // WebContentsViewAura. Wwe are sized via ...
8 years, 1 month ago (2012-10-25 17:22:52 UTC) #3
oshima
http://codereview.chromium.org/11270022/diff/4001/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): http://codereview.chromium.org/11270022/diff/4001/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1281 content/browser/renderer_host/render_widget_host_view_aura.cc:1281: // WebContentsViewAura. Wwe are sized via SetSize() or On ...
8 years, 1 month ago (2012-10-25 17:28:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11270022/8001
8 years, 1 month ago (2012-10-25 17:29:57 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 19:43:12 UTC) #6
Change committed as 164146

Powered by Google App Engine
This is Rietveld 408576698