[autofill] Adding new API to request an interactive autocomplete UI flow.

chrome/common/autofill_messages.h

Index: chrome/common/autofill_messages.h
diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h
index faf7e3c514a488a213c194d6d58fdd5825fabfb4..43eac69b9a42ac24fb1d0d2473d94bc6033b67a5 100644
--- a/chrome/common/autofill_messages.h
+++ b/chrome/common/autofill_messages.h
@@ -135,6 +135,10 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
 IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
                     content::PasswordForm /* form checked */)
 
+// Sent when interactive autocomplete is cancelled or finished successfully.
+IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteFinished,
+                    bool /* whether the user pressed cancel */)

[Evan Stade, 2012/10/26 03:23:02]

"whether the user pressed cancel" is very specific. What if the user presses
escape or presses the [x]? What if we run into some other kind of error that
prevents handling the request? For example, the request could originate from an
instant-loaded page, in which case we'd want to ignore it instead of showing a
UI. Therefore the bool should be described as "success/failure". Also I think
true should correlate to success.

[Ilya Sherman, 2012/10/26 03:30:52]

nit: Boolean parameters are hard to make sense of at the call site.  We
generally prefer enumerated values with descriptive names.

[Dan Beam, 2012/10/26 05:51:44]

I see 3 examples of bools in messages in this file that could be enums.  Is this
different?  Should we update the others?

+
 // Autofill messages sent from the renderer to the browser.
 
 // Notification that forms have been seen that are candidates for
@@ -191,6 +195,10 @@ IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidPreviewAutofillFormData)
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_DidFillAutofillFormData,
                     base::TimeTicks /* timestamp */)
 
+// Sent when a form receives a request to do interactive autocomplete.
+IPC_MESSAGE_ROUTED1(AutofillHostMsg_RequestAutocomplete,
+                    FormData /* the form */)
+
 // Instructs the browser to remove the specified Autocomplete entry from the
 // database.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_RemoveAutocompleteEntry,