Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/common/autofill_messages.h

Issue 11270018: [autofill] Adding new API to request an interactive autocomplete UI flow. (Closed) Base URL: svn://
Patch Set: do a barrel roll! Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/autofill_messages.h
diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h
index faf7e3c514a488a213c194d6d58fdd5825fabfb4..43eac69b9a42ac24fb1d0d2473d94bc6033b67a5 100644
--- a/chrome/common/autofill_messages.h
+++ b/chrome/common/autofill_messages.h
@@ -135,6 +135,10 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
content::PasswordForm /* form checked */)
+// Sent when interactive autocomplete is cancelled or finished successfully.
+ bool /* whether the user pressed cancel */)
Evan Stade 2012/10/26 03:23:02 "whether the user pressed cancel" is very specific
Ilya Sherman 2012/10/26 03:30:52 nit: Boolean parameters are hard to make sense of
Dan Beam 2012/10/26 05:51:44 I see 3 examples of bools in messages in this file
// Autofill messages sent from the renderer to the browser.
// Notification that forms have been seen that are candidates for
@@ -191,6 +195,10 @@ IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidPreviewAutofillFormData)
base::TimeTicks /* timestamp */)
+// Sent when a form receives a request to do interactive autocomplete.
+ FormData /* the form */)
// Instructs the browser to remove the specified Autocomplete entry from the
// database.

Powered by Google App Engine
This is Rietveld 408576698