Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/renderer/autofill/autofill_agent.h

Issue 11270018: [autofill] Adding new API to request an interactive autocomplete UI flow. (Closed) Base URL: svn://
Patch Set: newest Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/autofill_agent.h
diff --git a/chrome/renderer/autofill/autofill_agent.h b/chrome/renderer/autofill/autofill_agent.h
index 89f0a31c0084810a26752b1b56d7a7851c3d3f3a..a7d7d5970c0bff69306a78550f09974b9c80fe25 100644
--- a/chrome/renderer/autofill/autofill_agent.h
+++ b/chrome/renderer/autofill/autofill_agent.h
@@ -88,6 +88,9 @@ class AutofillAgent : public content::RenderViewObserver,
virtual void textFieldDidReceiveKeyDown(
const WebKit::WebInputElement& element,
const WebKit::WebKeyboardEvent& event) OVERRIDE;
+ virtual void didRequestAutocomplete(
+ WebKit::WebFrame* frame,
+ const WebKit::WebFormElement& form) OVERRIDE;
void OnSuggestionsReturned(int query_id,
const std::vector<string16>& values,
@@ -108,6 +111,9 @@ class AutofillAgent : public content::RenderViewObserver,
void OnAcceptDataListSuggestion(const string16& value);
void OnAcceptPasswordAutofillSuggestion(const string16& value);
+ // For interactive autocomplete.
+ void OnRequestAutocompleteFinished(int query_id, int result);
// Called in a posted task by textFieldDidChange() to work-around a WebKit bug
void TextFieldDidChangeImpl(const WebKit::WebInputElement& element);
@@ -163,6 +169,9 @@ class AutofillAgent : public content::RenderViewObserver,
// Set |node| to display the given |value|.
void SetNodeText(const string16& value, WebKit::WebInputElement* node);
+ // Hides any currently showing autofill popups.
Ilya Sherman 2012/10/27 07:44:11 nit: "autofill" -> "Autofill"
Dan Beam 2012/10/29 19:17:05 Done.
+ void HidePopups();
FormCache form_cache_;
PasswordAutofillManager* password_autofill_manager_; // WEAK reference.
@@ -174,6 +183,10 @@ class AutofillAgent : public content::RenderViewObserver,
// The element corresponding to the last request sent for form field Autofill.
WebKit::WebInputElement element_;
+ // The element corresponding to the last request sent for an interactive
+ // autocomplete.
+ WebKit::WebFormElement form_;
Ilya Sherman 2012/10/27 07:44:11 It doesn't seem like this will work if multiple ta
Evan Stade 2012/10/29 17:54:28 there's only one AutofillAgent per RenderView. Ren
Ilya Sherman 2012/10/29 17:59:23 Ok, that makes this much easier to reason about --
Dan Beam 2012/10/29 19:17:05 Currently, the webkit implementation will hit the
// The action to take when receiving Autofill data from the AutofillManager.
AutofillAction autofill_action_;

Powered by Google App Engine
This is Rietveld 408576698