Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: content/public/renderer/render_view_observer.h

Issue 11270018: [autofill] Adding new API to request an interactive autocomplete UI flow. (Closed) Base URL: svn://
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/render_view_observer.h
diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h
index 6999159d902573bf39e6fa9fbb49c8bd38f11c1b..a72fa8a0e2bb759de874a4b5cab446f6653d2fbc 100644
--- a/content/public/renderer/render_view_observer.h
+++ b/content/public/renderer/render_view_observer.h
@@ -82,6 +82,8 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,
virtual void ZoomLevelChanged() {};
virtual void DidChangeScrollOffset(WebKit::WebFrame* frame) {}
virtual void DraggableRegionsChanged(WebKit::WebFrame* frame) {}
+ virtual void RequestAutocomplete(WebKit::WebFrame* frame,
Evan Stade 2012/10/24 21:59:44 this doesn't look like it belongs here
Dan Beam 2012/10/26 03:06:05 this can stay, now, right?
Evan Stade 2012/10/26 03:23:02 no, I still don't believe this belongs. This one i
Ilya Sherman 2012/10/26 03:35:28 Really? This seems like the right place to me. C
Evan Stade 2012/10/26 03:52:53 perhaps ContentRendererClient instead.
Ilya Sherman 2012/10/26 04:03:33 Lots of the methods in RenderViewObserver are only
Evan Stade 2012/10/26 04:06:14 I didn't suggest that.
+ const WebKit::WebFormElement& form) {}
// These match the RenderView methods.
virtual void DidHandleMouseEvent(const WebKit::WebMouseEvent& event) {}

Powered by Google App Engine
This is Rietveld 408576698