[autofill] Adding new API to request an interactive autocomplete UI flow.

content/public/renderer/render_view_observer.h

Index: content/public/renderer/render_view_observer.h
diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h
index 6999159d902573bf39e6fa9fbb49c8bd38f11c1b..a72fa8a0e2bb759de874a4b5cab446f6653d2fbc 100644
--- a/content/public/renderer/render_view_observer.h
+++ b/content/public/renderer/render_view_observer.h
@@ -82,6 +82,8 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,
   virtual void ZoomLevelChanged() {};
   virtual void DidChangeScrollOffset(WebKit::WebFrame* frame) {}
   virtual void DraggableRegionsChanged(WebKit::WebFrame* frame) {}
+  virtual void RequestAutocomplete(WebKit::WebFrame* frame,

[Evan Stade, 2012/10/24 21:59:44]

this doesn't look like it belongs here

[Dan Beam, 2012/10/26 03:06:05]

this can stay, now, right?

[Evan Stade, 2012/10/26 03:23:02]

no, I still don't believe this belongs. This one is not like the others; it's
not a "change to the frame". Then again, neither is PrintPage --- that one
doesn't seem to fit in either. Maybe you can ask jam@ for his opinion. I wonder
if adding a RenderViewDelegate which dispatches calls like this on the chrome
side would make sense?

[Ilya Sherman, 2012/10/26 03:35:28]

Really?  This seems like the right place to me.  Certainly we'll want jam@ to
review this though.

[Evan Stade, 2012/10/26 03:52:53]

perhaps ContentRendererClient instead.
do you expect that more than one thing will want to "Observe" this API call?
Does this API call represent a change to the frame?

[Ilya Sherman, 2012/10/26 04:03:33]

Lots of the methods in RenderViewObserver are only observed by one class.  The
advantage of adding this method to this class is that the RenderView only needs
to keep track of one list of observers.  If we create a new AutofillObserver
class, the RenderView needs to keep track of a list of AutofillObservers.  The
whole point of the RenderViewObserver class initially was to decouple the
RenderView from having to know about all the different types of observers it
has.

Anyway, we can see what John says, but the above is why I think it probably
makes sense to keep this method in this class.

[Evan Stade, 2012/10/26 04:06:14]

I didn't suggest that.
yes, it will be up to John.

+                                   const WebKit::WebFormElement& form) {}
 
   // These match the RenderView methods.
   virtual void DidHandleMouseEvent(const WebKit::WebMouseEvent& event) {}