[autofill] Adding new API to request an interactive autocomplete UI flow.

chrome/renderer/autofill/autofill_agent.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_
 #define CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 42 matching lines @@
 
   // RenderView::Observer:
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
   virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
   virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE;
   virtual void FrameWillClose(WebKit::WebFrame* frame) OVERRIDE;
   virtual void WillSubmitForm(WebKit::WebFrame* frame,
                               const WebKit::WebFormElement& form) OVERRIDE;
   virtual void ZoomLevelChanged() OVERRIDE;
   virtual void DidChangeScrollOffset(WebKit::WebFrame* frame) OVERRIDE;
+  virtual void RequestAutocomplete(WebKit::WebFrame* frame,
+                                   const WebKit::WebFormElement& form) OVERRIDE;
 
   // PageClickListener:
   virtual bool InputElementClicked(const WebKit::WebInputElement& element,
                                    bool was_focused,
                                    bool is_focused) OVERRIDE;
   virtual bool InputElementLostFocus() OVERRIDE;
 
   // WebKit::WebAutofillClient:

[Evan Stade, 2012/10/24 21:59:44]

this looks for all the world like the place RequestAutocomplete belongs

[Dan Beam, 2012/10/26 03:06:05]

I thought so at first as well, but it ended up being not particularly where I
wanted in webkit.  I asked isherman@ about it and he agreed.  He also mentioned
that csharp@ is moving much of this to the browser for greater control of the
UI?

[Ilya Sherman, 2012/10/26 03:35:28]

Yeah, the WebAutofillClient is all about the existing popup UI, and is being
deleted because the UI is moving into the browser process.

   virtual void didAcceptAutofillSuggestion(const WebKit::WebNode& node,
                                            const WebKit::WebString& value,
                                            const WebKit::WebString& label,
                                            int item_id,
                                            unsigned index) OVERRIDE;
   virtual void didSelectAutofillSuggestion(const WebKit::WebNode& node,
                                            const WebKit::WebString& value,
                                            const WebKit::WebString& label,
                                            int item_id) OVERRIDE;
   virtual void didClearAutofillSelection(const WebKit::WebNode& node) OVERRIDE;
@@ skipping 117 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, WaitUsername);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionAccept);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionSelect);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_RENDERER_AUTOFILL_AUTOFILL_AGENT_H_