Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 11269047: Add a comment for the class TabSpecificContentSettings (Closed)

Created:
8 years, 1 month ago by markusheintz_
Modified:
8 years, 1 month ago
CC:
chromium-reviews, markusheintz_
Visibility:
Public.

Description

Add a comment for the class TabSpecificContentSettings BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164362

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : Address comments (jochen) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/content_settings/tab_specific_content_settings.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
markusheintz_
I bothers me that the TabSpecificContentSettings class has no comment. So here is my first ...
8 years, 1 month ago (2012-10-25 14:58:00 UTC) #1
Bernhard Bauer
lgtm
8 years, 1 month ago (2012-10-25 15:15:27 UTC) #2
plz use chromium.org account
It's not entirely correct, it also tracks if and which content accessed (not only blocked) ...
8 years, 1 month ago (2012-10-25 16:03:06 UTC) #3
markusheintz_
Addressed comments.
8 years, 1 month ago (2012-10-25 16:22:45 UTC) #4
marja
lgtm
8 years, 1 month ago (2012-10-25 16:29:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/11269047/6001
8 years, 1 month ago (2012-10-26 07:27:00 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-10-26 19:29:20 UTC) #7
Change committed as 164362

Powered by Google App Engine
This is Rietveld 408576698