Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 11269043: Make the title of Chrome OS Audio Player empty (Closed)

Created:
8 years, 1 month ago by Vladislav Kaznacheev
Modified:
8 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, feature-media-reviews_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make the title of Chrome OS Audio Player empty BUG=151847 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164194

Patch Set 1 #

Patch Set 2 : Accounted for the changed title bar height #

Total comments: 1

Patch Set 3 : Addressed comments #

Patch Set 4 : Added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M chrome/browser/chromeos/media/media_player.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/media/media_player_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player_extension_api.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/media/audio_player.js View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vladislav Kaznacheev
8 years, 1 month ago (2012-10-25 13:31:06 UTC) #1
dgozman
LGTM https://chromiumcodereview.appspot.com/11269043/diff/2001/chrome/browser/resources/file_manager/js/media/audio_player.js File chrome/browser/resources/file_manager/js/media/audio_player.js (right): https://chromiumcodereview.appspot.com/11269043/diff/2001/chrome/browser/resources/file_manager/js/media/audio_player.js#newcode393 chrome/browser/resources/file_manager/js/media/audio_player.js:393: AudioPlayer.CONTROLS_HEIGHT; strange indentation
8 years, 1 month ago (2012-10-25 13:39:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/11269043/1003
8 years, 1 month ago (2012-10-25 15:48:26 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-10-25 18:05:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/11269043/12001
8 years, 1 month ago (2012-10-25 19:55:25 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 22:25:32 UTC) #6
Change committed as 164194

Powered by Google App Engine
This is Rietveld 408576698