Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4696)

Unified Diff: chrome/installer/util/chrome_app_host_distribution.cc

Issue 11267023: Implementing --app-launcher install/uninstall flow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits; added localized string for App Launcher uninstall shortcut. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/channel_info.cc ('k') | chrome/installer/util/chrome_app_host_operations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/chrome_app_host_distribution.cc
diff --git a/chrome/installer/util/chrome_app_host_distribution.cc b/chrome/installer/util/chrome_app_host_distribution.cc
index da20de6eea52160ba90b34098ae5ed3d09c03557..112678e430f84ec1fb76b1c7d2747661fc97bced 100644
--- a/chrome/installer/util/chrome_app_host_distribution.cc
+++ b/chrome/installer/util/chrome_app_host_distribution.cc
@@ -60,15 +60,15 @@ string16 ChromeAppHostDistribution::GetPublisherName() {
}
string16 ChromeAppHostDistribution::GetAppDescription() {
- NOTREACHED() << "This should never be accessed due to no start-menu/task-bar "
- << "shortcuts.";
- return L"A standalone platform for Chrome apps.";
+ const string16& app_description =
+ installer::GetLocalizedString(IDS_APP_LAUNCHER_SHORTCUT_TOOLTIP_BASE);
+ return app_description;
}
string16 ChromeAppHostDistribution::GetLongAppDescription() {
- NOTREACHED() << "This should never be accessed as Chrome App Host is not a "
- << "default browser option.";
- return L"A standalone platform for Chrome apps.";
+ const string16& app_description =
+ installer::GetLocalizedString(IDS_APP_LAUNCHER_PRODUCT_DESCRIPTION_BASE);
+ return app_description;
}
std::string ChromeAppHostDistribution::GetSafeBrowsingName() {
@@ -102,14 +102,12 @@ std::string ChromeAppHostDistribution::GetHttpPipeliningTestServer() const {
}
string16 ChromeAppHostDistribution::GetUninstallLinkName() {
- NOTREACHED() << "This should never be accessed as Chrome App Host has no "
- << "uninstall entry.";
- return L"Uninstall Chrome App Host";
+ const string16& link_name =
+ installer::GetLocalizedString(IDS_UNINSTALL_APP_LAUNCHER_BASE);
+ return link_name;
}
string16 ChromeAppHostDistribution::GetUninstallRegPath() {
- NOTREACHED() << "This should never be accessed as Chrome App Host has no "
- << "uninstall entry.";
return L"Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\"
L"Google Chrome App Host";
}
« no previous file with comments | « chrome/installer/util/channel_info.cc ('k') | chrome/installer/util/chrome_app_host_operations.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698