Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 11266037: Allow lastchange.py to be used for arbitrary repositories. (Closed)

Created:
8 years, 1 month ago by chrisha
Modified:
8 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Allow lastchange.py to be used for arbitrary repositories. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164172

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed maruel's nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/util/lastchange.py View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
chrisha
(This allows us to reuse this script for Syzygy's build.) PTAL.
8 years, 1 month ago (2012-10-25 15:22:14 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/11266037/diff/1/build/util/lastchange.py File build/util/lastchange.py (right): http://codereview.chromium.org/11266037/diff/1/build/util/lastchange.py#newcode216 build/util/lastchange.py:216: src_dir = os.path.dirname(sys.argv[0]) not always a good idea. ...
8 years, 1 month ago (2012-10-25 17:56:01 UTC) #2
chrisha
Thanks, committing. http://codereview.chromium.org/11266037/diff/1/build/util/lastchange.py File build/util/lastchange.py (right): http://codereview.chromium.org/11266037/diff/1/build/util/lastchange.py#newcode216 build/util/lastchange.py:216: src_dir = os.path.dirname(sys.argv[0]) On 2012/10/25 17:56:01, Marc-Antoine ...
8 years, 1 month ago (2012-10-25 17:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/11266037/2002
8 years, 1 month ago (2012-10-25 17:59:22 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 20:59:38 UTC) #5
Change committed as 164172

Powered by Google App Engine
This is Rietveld 408576698