Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: chrome/browser/ssl/ssl_add_certificate_android.cc

Issue 11266008: Fix certificate and keychain installation on Android. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: separate android and openssl CertDatabase implementations Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_add_certificate.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ssl/ssl_add_certificate.h"
6
7 #include "net/android/network_library.h"
8
9 namespace chrome {
10
11 // Special case for Android here for several reasons:
12 //
13 // - The SSLAddCertHandler implementation currently only supports
14 // CERTIFICATE_TYPE_X509_USER_CERT, but not other types, like
15 // CERTIFICATE_TYPE_PKCS12_ARCHIVE which are required on this
16 // platform.
17 //
18 // - Besides, SSLAddCertHandler tries to parse the certificate
19 // by calling net::CertDatabase::CheckUserCert() which is not
20 // implemented on Android, mainly because there is no API
21 // provided by the system to do that properly.
22 //
23 // - The Android CertInstaller activity will check the certificate file
24 // and display a toast (small fading dialog) to the user if it is
25 // not valid, so the UI performed by SSLAddCertHandler would
26 // be redundant.
27 void SSLAddCertificate(
28 net::URLRequest* /* request */,
29 net::CertificateMimeType cert_type,
30 const void* cert_data,
31 size_t cert_size,
32 int /* render_process_id */,
33 int /* render_view_id */) {
34 if (cert_size > 0) {
35 // This launches a new activity which will run in a different process.
36 // It handles all user interaction, so no need to do anything in the
37 // browser UI thread here.
38 net::android::StoreCertificate(cert_type, cert_data, cert_size);
39 }
40 }
41
42 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ssl/ssl_add_certificate.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698