Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: net/base/cert_database_openssl.cc

Issue 11266008: Fix certificate and keychain installation on Android. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: remove obsolete constants Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/android/network_library.cc ('k') | net/base/mime_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/cert_database.h" 5 #include "net/base/cert_database.h"
6 6
7 #include <openssl/x509.h> 7 #include <openssl/x509.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/observer_list_threadsafe.h" 10 #include "base/observer_list_threadsafe.h"
11 #include "net/base/crypto_module.h" 11 #include "net/base/crypto_module.h"
12 #include "net/base/net_errors.h" 12 #include "net/base/net_errors.h"
13 #include "net/base/openssl_private_key_store.h" 13 #include "net/base/openssl_private_key_store.h"
14 #include "net/base/x509_certificate.h" 14 #include "net/base/x509_certificate.h"
15 15
16 namespace net { 16 namespace net {
17 17
18 CertDatabase::CertDatabase() 18 CertDatabase::CertDatabase()
19 : observer_list_(new ObserverListThreadSafe<Observer>) { 19 : observer_list_(new ObserverListThreadSafe<Observer>) {
20 } 20 }
21 21
22 CertDatabase::~CertDatabase() {} 22 CertDatabase::~CertDatabase() {}
23 23
24 int CertDatabase::CheckUserCert(X509Certificate* cert) { 24 int CertDatabase::CheckUserCert(X509Certificate* cert) {
25 #if defined(OS_ANDROID)
darin (slow to review) 2012/12/11 00:00:08 nit: Would it make more sense to create a CertData
26 // NOTE: This method shall never be called on Android.
27 //
28 // On other platforms, it is only used by the SSLAddCertHandler class
29 // to handle veritication and installation of downloaded certificates.
30 //
31 // On Android, the certificate data is passed directly to the system's
32 // CertInstaller activity, which handles verification, naming,
33 // installation and UI (for success/failure).
34 NOTIMPLEMENTED();
35 return ERR_NOT_IMPLEMENTED;
36 #else // OS_ANDROID
25 if (!cert) 37 if (!cert)
26 return ERR_CERT_INVALID; 38 return ERR_CERT_INVALID;
27 if (cert->HasExpired()) 39 if (cert->HasExpired())
28 return ERR_CERT_DATE_INVALID; 40 return ERR_CERT_DATE_INVALID;
29 41
30 if (!OpenSSLPrivateKeyStore::GetInstance()->FetchPrivateKey( 42 if (!OpenSSLPrivateKeyStore::GetInstance()->FetchPrivateKey(
31 X509_PUBKEY_get(X509_get_X509_PUBKEY(cert->os_cert_handle())))) 43 X509_PUBKEY_get(X509_get_X509_PUBKEY(cert->os_cert_handle()))))
32 return ERR_NO_PRIVATE_KEY_FOR_CERT; 44 return ERR_NO_PRIVATE_KEY_FOR_CERT;
33 45
34 return OK; 46 return OK;
47 #endif // OS_ANDROID
35 } 48 }
36 49
37 int CertDatabase::AddUserCert(X509Certificate* cert) { 50 int CertDatabase::AddUserCert(X509Certificate* cert) {
38 // TODO(bulach): implement me.
39 NOTIMPLEMENTED(); 51 NOTIMPLEMENTED();
40 return ERR_NOT_IMPLEMENTED; 52 return ERR_NOT_IMPLEMENTED;
41 } 53 }
42 54
43 } // namespace net 55 } // namespace net
OLDNEW
« no previous file with comments | « net/android/network_library.cc ('k') | net/base/mime_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698