Fix certificate and keychain installation on Android.

content/browser/renderer_host/buffered_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/buffered_resource_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "content/browser/download/download_resource_handler.h"
 #include "content/browser/download/download_stats.h"
 #include "content/browser/plugin_service_impl.h"
 #include "content/browser/renderer_host/resource_dispatcher_host_impl.h"
 #include "content/browser/renderer_host/resource_request_info_impl.h"
-#include "content/browser/renderer_host/x509_user_cert_resource_handler.h"
+#include "content/browser/renderer_host/certificate_resource_handler.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/download_save_info.h"
 #include "content/public/browser/resource_context.h"
 #include "content/public/browser/resource_dispatcher_host_delegate.h"
 #include "content/public/common/resource_response.h"
 #include "net/base/io_buffer.h"
 #include "net/base/mime_sniffer.h"
 #include "net/base/mime_util.h"
 #include "net/base/net_errors.h"
@@ skipping 267 matching lines @@
 
   return made_final_decision;
 }
 
 bool BufferedResourceHandler::SelectNextHandler(bool* defer) {
   DCHECK(!response_->head.mime_type.empty());
 
   ResourceRequestInfoImpl* info = ResourceRequestInfoImpl::ForRequest(request_);
   const std::string& mime_type = response_->head.mime_type;
 
-  if (mime_type == "application/x-x509-user-cert") {
-    // Install X509 handler.
+  if (net::IsSupportedCertificateMimeType(mime_type)) {

[darin (slow to review), 2012/10/26 07:34:05]

I'm pretty sure the existing code is wrongly integrated here.  Please confirm,
but I don't think <img src="certificate"> is supposed to trigger the
CertificateResourceHandler, yet it does.  I think certificate handling should be
integrated into the download system much in the same way as CRX handling is.

[digit1, 2012/10/26 11:38:10]

In his original comment at https://codereview.chromium.org/11031043/, Ryan
agrees with you. He describes a short-term fix as well as a long-term one, where
the latter would move all this certificate download code to a better location.

This current patch corresponds to the short-term fix only. If you think this is
important, I can try to handle the long-term fix too (with an intermediate patch
before another revision of this one), but in this case, I would appreciate a few
pointers / clarifications about which layers / source files would likely be
impacted.

+    // Install crypto file.

[Ryan Sleevi, 2012/11/13 19:37:50]

nit: crypto file

[digit1, 2012/11/15 17:42:14]

Done.

     scoped_ptr<ResourceHandler> handler(
-        new X509UserCertResourceHandler(request_,
-                                        info->GetChildID(),
-                                        info->GetRouteID()));
+        new CertificateResourceHandler(request_,
+                                       info->GetChildID(),
+                                       info->GetRouteID()));
     return UseAlternateNextHandler(handler.Pass());
   }
 
   if (!info->allow_download())
     return true;
 
   if (!MustDownload()) {
     if (net::IsSupportedMimeType(mime_type))
       return true;
 
@@ skipping 131 matching lines @@
     const std::vector<webkit::WebPluginInfo>& plugins) {
   bool defer = false;
   if (!ProcessResponse(&defer)) {
     controller()->Cancel();
   } else if (!defer) {
     controller()->Resume();
   }
 }
 
 }  // namespace content