Issue 11262034: Upstream remaining differences in android/build python files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11262034: Upstream remaining differences in android/build python files (Closed)

Created:
8 years, 1 month ago by aberent

Modified:
8 years, 1 month ago

Reviewers:
bulach, Anthony Berent

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Upstream remaining differences in android/build python files Re-enable unit tests in single_test_runner (these are no longer flaky) Allow stack trace, since we now admit we are doing an Android version of Chrome Add keep_test_server_ports option to instrumentation tests. BUG=136980 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164117

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -19 lines)			Patch
M	build/android/pylib/single_test_runner.py	View	3 chunks	+13 lines, -15 lines	2 comments	Download
M	build/android/pylib/test_options_parser.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	build/android/run_instrumentation_tests.py	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anthony Berent

https://codereview.chromium.org/11262034/diff/1/build/android/pylib/single_test_runner.py File build/android/pylib/single_test_runner.py (left): https://codereview.chromium.org/11262034/diff/1/build/android/pylib/single_test_runner.py#oldcode73 build/android/pylib/single_test_runner.py:73: # False) No longer flaky https://codereview.chromium.org/11262034/diff/1/build/android/pylib/single_test_runner.py#oldcode226 build/android/pylib/single_test_runner.py:226: return data ...

8 years, 1 month ago (2012-10-25 16:02:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/11262034/1

8 years, 1 month ago (2012-10-25 16:45:06 UTC) #3

Change committed as 164117

Expand Messages | Collapse Messages