Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3182)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java

Issue 1126203011: Start displaying title text for HTML elements without links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
index 62769b1b35794ff2ccd1e993255e07584f1dff81..71d168f49867db22c1164d08d81cbf876300f131 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
@@ -42,6 +42,7 @@ public class ContextMenuParams {
private final String mPageUrl;
private final String mLinkUrl;
private final String mLinkText;
+ private final String mTitleText;
private final String mUnfilteredLinkUrl;
private final String mSrcUrl;
private final boolean mImageWasFetchedLoFi;
@@ -111,6 +112,13 @@ public class ContextMenuParams {
}
/**
+ * @return The title or alt attribute (if title is not available).
+ */
+ public String getTitleText() {
+ return mTitleText;
+ }
+
+ /**
* @return The unfiltered link URL, if any.
*/
public String getUnfilteredLinkUrl() {
@@ -174,11 +182,12 @@ public class ContextMenuParams {
}
private ContextMenuParams(int mediaType, String pageUrl, String linkUrl, String linkText,
- String unfilteredLinkUrl, String srcUrl, String selectionText,
+ String unfilteredLinkUrl, String srcUrl, String selectionText, String titleText,
boolean imageWasFetchedLoFi, boolean isEditable, Referrer referrer) {
mPageUrl = pageUrl;
mLinkUrl = linkUrl;
mLinkText = linkText;
+ mTitleText = titleText;
mUnfilteredLinkUrl = unfilteredLinkUrl;
mSrcUrl = srcUrl;
mImageWasFetchedLoFi = imageWasFetchedLoFi;
@@ -194,12 +203,12 @@ public class ContextMenuParams {
@CalledByNative
private static ContextMenuParams create(int mediaType, String pageUrl, String linkUrl,
String linkText, String unfilteredLinkUrl, String srcUrl, String selectionText,
- boolean imageWasFetchedLoFi, boolean isEditable, String sanitizedReferrer,
- int referrerPolicy) {
+ String titleText, boolean imageWasFetchedLoFi, boolean isEditable,
+ String sanitizedReferrer, int referrerPolicy) {
Referrer referrer = TextUtils.isEmpty(sanitizedReferrer)
? null : new Referrer(sanitizedReferrer, referrerPolicy);
return new ContextMenuParams(mediaType, pageUrl, linkUrl, linkText, unfilteredLinkUrl,
- srcUrl, selectionText, imageWasFetchedLoFi, isEditable, referrer);
+ srcUrl, selectionText, titleText, imageWasFetchedLoFi, isEditable, referrer);
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698