Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java

Issue 1126203011: Start displaying title text for HTML elements without links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
index 861cd9b958da1a755650779bb886f0db948b43ac..e51c0dda7a01bbdd5c16484c5110ccb697b99b11 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
@@ -42,6 +42,7 @@ public class ContextMenuParams {
private final String mPageUrl;
private final String mLinkUrl;
private final String mLinkText;
+ private final String mTitleText;
private final String mUnfilteredLinkUrl;
private final String mSrcUrl;
private final boolean mIsEditable;
@@ -110,6 +111,13 @@ public class ContextMenuParams {
}
/**
+ * @return The title or alt atribute (if title is not available).
Ted C 2015/05/15 23:24:55 two ts in attribute
aurimas (slooooooooow) 2015/05/15 23:34:11 Done
+ */
+ public String getTitleText() {
+ return mTitleText;
+ }
+
+ /**
* @return The unfiltered link URL, if any.
*/
public String getUnfilteredLinkUrl() {
@@ -166,11 +174,12 @@ public class ContextMenuParams {
}
private ContextMenuParams(int mediaType, String pageUrl, String linkUrl, String linkText,
- String unfilteredLinkUrl, String srcUrl, String selectionText, boolean isEditable,
- Referrer referrer) {
+ String unfilteredLinkUrl, String srcUrl, String selectionText, String titleText,
+ boolean isEditable, Referrer referrer) {
mPageUrl = pageUrl;
mLinkUrl = linkUrl;
mLinkText = linkText;
+ mTitleText = titleText;
mUnfilteredLinkUrl = unfilteredLinkUrl;
mSrcUrl = srcUrl;
mIsEditable = isEditable;
@@ -185,11 +194,11 @@ public class ContextMenuParams {
@CalledByNative
private static ContextMenuParams create(int mediaType, String pageUrl, String linkUrl,
String linkText, String unfilteredLinkUrl, String srcUrl, String selectionText,
- boolean isEditable, String sanitizedReferrer, int referrerPolicy) {
+ String titleText, boolean isEditable, String sanitizedReferrer, int referrerPolicy) {
Referrer referrer = TextUtils.isEmpty(sanitizedReferrer)
? null : new Referrer(sanitizedReferrer, referrerPolicy);
return new ContextMenuParams(mediaType, pageUrl, linkUrl, linkText, unfilteredLinkUrl,
- srcUrl, selectionText, isEditable, referrer);
+ srcUrl, selectionText, titleText, isEditable, referrer);
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698