Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/ui/android/context_menu_helper.cc

Issue 1126203011: Start displaying title text for HTML elements without links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/context_menu_helper.h" 5 #include "chrome/browser/ui/android/context_menu_helper.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_heade rs.h" 9 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_heade rs.h"
10 #include "content/public/browser/android/content_view_core.h" 10 #include "content/public/browser/android/content_view_core.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 base::android::ScopedJavaLocalRef<jobject> jmenu_info = 86 base::android::ScopedJavaLocalRef<jobject> jmenu_info =
87 ContextMenuParamsAndroid::Java_ContextMenuParams_create( 87 ContextMenuParamsAndroid::Java_ContextMenuParams_create(
88 env, 88 env,
89 params.media_type, 89 params.media_type,
90 ConvertUTF8ToJavaString(env, params.page_url.spec()).obj(), 90 ConvertUTF8ToJavaString(env, params.page_url.spec()).obj(),
91 ConvertUTF8ToJavaString(env, params.link_url.spec()).obj(), 91 ConvertUTF8ToJavaString(env, params.link_url.spec()).obj(),
92 ConvertUTF16ToJavaString(env, params.link_text).obj(), 92 ConvertUTF16ToJavaString(env, params.link_text).obj(),
93 ConvertUTF8ToJavaString(env, params.unfiltered_link_url.spec()).obj(), 93 ConvertUTF8ToJavaString(env, params.unfiltered_link_url.spec()).obj(),
94 ConvertUTF8ToJavaString(env, params.src_url.spec()).obj(), 94 ConvertUTF8ToJavaString(env, params.src_url.spec()).obj(),
95 ConvertUTF16ToJavaString(env, params.selection_text).obj(), 95 ConvertUTF16ToJavaString(env, params.selection_text).obj(),
96 ConvertUTF16ToJavaString(env, params.title_text).obj(),
96 image_was_fetched_lo_fi, 97 image_was_fetched_lo_fi,
97 params.is_editable, 98 params.is_editable,
98 ConvertUTF8ToJavaString(env, sanitizedReferrer.spec()).obj(), 99 ConvertUTF8ToJavaString(env, sanitizedReferrer.spec()).obj(),
99 params.referrer_policy); 100 params.referrer_policy);
100 101
101 std::vector<content::MenuItem>::const_iterator i; 102 std::vector<content::MenuItem>::const_iterator i;
102 for (i = params.custom_items.begin(); i != params.custom_items.end(); ++i) { 103 for (i = params.custom_items.begin(); i != params.custom_items.end(); ++i) {
103 ContextMenuParamsAndroid::Java_ContextMenuParams_addCustomItem( 104 ContextMenuParamsAndroid::Java_ContextMenuParams_addCustomItem(
104 env, 105 env,
105 jmenu_info.obj(), 106 jmenu_info.obj(),
(...skipping 19 matching lines...) Expand all
125 content::DownloadControllerAndroid::Get()->StartContextMenuDownload( 126 content::DownloadControllerAndroid::Get()->StartContextMenuDownload(
126 context_menu_params_, 127 context_menu_params_,
127 web_contents_, 128 web_contents_,
128 jis_link); 129 jis_link);
129 } 130 }
130 131
131 bool RegisterContextMenuHelper(JNIEnv* env) { 132 bool RegisterContextMenuHelper(JNIEnv* env) {
132 return RegisterNativesImpl(env) && 133 return RegisterNativesImpl(env) &&
133 ContextMenuParamsAndroid::RegisterNativesImpl(env); 134 ContextMenuParamsAndroid::RegisterNativesImpl(env);
134 } 135 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698