Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1126203011: Start displaying title text for HTML elements without links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 1139 matching lines...) Expand 10 before | Expand all | Expand 10 after
1150 // If this RFH wasn't pending deletion, then it is now swapped out. 1150 // If this RFH wasn't pending deletion, then it is now swapped out.
1151 SetState(RenderFrameHostImpl::STATE_SWAPPED_OUT); 1151 SetState(RenderFrameHostImpl::STATE_SWAPPED_OUT);
1152 } 1152 }
1153 1153
1154 void RenderFrameHostImpl::OnContextMenu(const ContextMenuParams& params) { 1154 void RenderFrameHostImpl::OnContextMenu(const ContextMenuParams& params) {
1155 // Validate the URLs in |params|. If the renderer can't request the URLs 1155 // Validate the URLs in |params|. If the renderer can't request the URLs
1156 // directly, don't show them in the context menu. 1156 // directly, don't show them in the context menu.
1157 ContextMenuParams validated_params(params); 1157 ContextMenuParams validated_params(params);
1158 RenderProcessHost* process = GetProcess(); 1158 RenderProcessHost* process = GetProcess();
1159 1159
1160
Ted C 2015/05/15 23:24:55 ?
aurimas (slooooooooow) 2015/05/15 23:34:11 Had logs in there. Done.
1160 // We don't validate |unfiltered_link_url| so that this field can be used 1161 // We don't validate |unfiltered_link_url| so that this field can be used
1161 // when users want to copy the original link URL. 1162 // when users want to copy the original link URL.
1162 process->FilterURL(true, &validated_params.link_url); 1163 process->FilterURL(true, &validated_params.link_url);
1163 process->FilterURL(true, &validated_params.src_url); 1164 process->FilterURL(true, &validated_params.src_url);
1164 process->FilterURL(false, &validated_params.page_url); 1165 process->FilterURL(false, &validated_params.page_url);
1165 process->FilterURL(true, &validated_params.frame_url); 1166 process->FilterURL(true, &validated_params.frame_url);
1166 1167
1167 delegate_->ShowContextMenu(this, validated_params); 1168 delegate_->ShowContextMenu(this, validated_params);
1168 } 1169 }
1169 1170
(...skipping 923 matching lines...) Expand 10 before | Expand all | Expand 10 after
2093 // We may be returning to an existing NavigationEntry that had been granted 2094 // We may be returning to an existing NavigationEntry that had been granted
2094 // file access. If this is a different process, we will need to grant the 2095 // file access. If this is a different process, we will need to grant the
2095 // access again. The files listed in the page state are validated when they 2096 // access again. The files listed in the page state are validated when they
2096 // are received from the renderer to prevent abuse. 2097 // are received from the renderer to prevent abuse.
2097 if (request_params.page_state.IsValid()) { 2098 if (request_params.page_state.IsValid()) {
2098 render_view_host_->GrantFileAccessFromPageState(request_params.page_state); 2099 render_view_host_->GrantFileAccessFromPageState(request_params.page_state);
2099 } 2100 }
2100 } 2101 }
2101 2102
2102 } // namespace content 2103 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698