Remove unused / unnecessary stuff from Instant.

Remove unused / unnecessary stuff from Instant.

+ Remove the SILENT, HIDDEN and SUGGEST modes.
+ Remove the DELAYED completion behaviour and related animation code.
+ Remove the delegate interface between InstantLoader and
  InstantController. These two are part of the same package, and it's
  unlikely that InstantLoader will ever be used by anything else.
+ Remove the delegate interface between InstantController and
  BrowserInstantController. This interface was originally established to
  ensure that Instant wouldn't reach into arbitrary parts of the Browser
  (at that time, there was no BrowserInstantController). Now,
  BrowserInstantController serves the same purpose as the interface, so
  there's no need for yet another layer in between.
+ Change DISALLOW_IMPLICIT_CONSTRUCTORS to DISALLOW_COPY_AND_ASSIGN
  (with apologies to @dhollowa) in classes which already have another
  constructor. IMPLICIT adds no value in these cases, and
  COPY_AND_ASSIGN is a more commonly recognized idiom.

BUG=none
R=sky@chromium.org
TEST=none; no change in functionality.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164005

[sreeram, 2012-10-24 19:26:59]

Please review.

[sky, 2012-10-24 21:40:40]

http://codereview.chromium.org/11262015/diff/1/chrome/browser/ui/views/locati...
File chrome/browser/ui/views/location_bar/suggested_text_view.h (right):

http://codereview.chromium.org/11262015/diff/1/chrome/browser/ui/views/locati...
chrome/browser/ui/views/location_bar/suggested_text_view.h:14: explicit
SuggestedTextView(bool instant_extended_api_enabled);
Can we get rid of this class entirely now?

[sreeram, 2012-10-24 22:16:14]

http://codereview.chromium.org/11262015/diff/1/chrome/browser/ui/views/locati...
File chrome/browser/ui/views/location_bar/suggested_text_view.h (right):

http://codereview.chromium.org/11262015/diff/1/chrome/browser/ui/views/locati...
chrome/browser/ui/views/location_bar/suggested_text_view.h:14: explicit
SuggestedTextView(bool instant_extended_api_enabled);
On 2012/10/24 21:40:40, sky wrote:
> Can we get rid of this class entirely now?

Done.

[sky, 2012-10-24 23:49:19]

LGTM

[commit-bot: I haz the power, 2012-10-24 23:55:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sreeram@chromium.org/11262015/1036

[commit-bot: I haz the power, 2012-10-25 03:21:56]

Change committed as 164005