Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 11260002: Fix invalid bind usage during AudioManagerBase construction. (Closed)

Created:
8 years, 2 months ago by DaleCurtis
Modified:
8 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Fix invalid bind usage during AudioManagerBase construction. Doh, the old way was not correct at all. We're using this before construction completes. /shame Fixes a bunch of tsan error reports from the original CL: http://codereview.chromium.org/11175066/ BUG=none TEST=unit tests still pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163770

Patch Set 1 #

Patch Set 2 : Gotta catch'em all. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M media/audio/audio_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/audio/audio_manager.cc View 2 chunks +8 lines, -1 line 0 comments Download
M media/audio/audio_manager_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
8 years, 2 months ago (2012-10-24 01:13:20 UTC) #1
Ami GONE FROM CHROMIUM
LGTM
8 years, 2 months ago (2012-10-24 01:29:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11260002/1
8 years, 2 months ago (2012-10-24 01:31:13 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 2 months ago (2012-10-24 01:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11260002/9
8 years, 2 months ago (2012-10-24 02:09:04 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-24 04:23:50 UTC) #6
Change committed as 163770

Powered by Google App Engine
This is Rietveld 408576698