media/video/capture/linux/v4l2_capture_delegate_multi_plane.cc - Issue 1124723006: VideoCaptureDeviceLinux: Add support for SPLANE+DMABUF V4L2 type capture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/linux/v4l2_capture_delegate_multi_plane.cc

Issue 1124723006: VideoCaptureDeviceLinux: Add support for SPLANE+DMABUF V4L2 type capture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: posciak@ review and rebase (AsPlatformFile(), ...BufferPoolUtilization...)). Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/video/capture/linux/v4l2_capture_delegate_multi_plane.h ('k') | media/video/capture/linux/v4l2_capture_delegate_single_plane.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/linux/v4l2_capture_delegate_multi_plane.cc

diff --git a/media/video/capture/linux/v4l2_capture_delegate_multi_plane.cc b/media/video/capture/linux/v4l2_capture_delegate_multi_plane.cc

index 99f70cebdd785c2ce80ac54d337ce397d2ceb32d..8c3239f32abada721caf19f14c16809decf7afd4 100644

--- a/media/video/capture/linux/v4l2_capture_delegate_multi_plane.cc

+++ b/media/video/capture/linux/v4l2_capture_delegate_multi_plane.cc

@@ -14,6 +14,7 @@ V4L2CaptureDelegateMultiPlane::V4L2CaptureDelegateMultiPlane(

int power_line_frequency)

: V4L2CaptureDelegate(device_name,

v4l2_task_runner,

+ V4L2_MEMORY_MMAP,

power_line_frequency) {

}

@@ -46,7 +47,8 @@ bool V4L2CaptureDelegateMultiPlane::FillV4L2Format(

}

void V4L2CaptureDelegateMultiPlane::FinishFillingV4L2Buffer(

- v4l2_buffer* buffer) const {

+ v4l2_buffer* buffer,

+ bool /* for_enqueue */) const {

buffer->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;

buffer->length = v4l2_planes_.size();