Issue 11246005: [Panels] Fix crash when killing panel extension from TaskManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11246005: [Panels] Fix crash when killing panel extension from TaskManager. (Closed)

Created:
8 years, 2 months ago by jennb

Modified:
8 years, 2 months ago

Reviewers:
yoshiki

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Panels] Fix crash when killing panel extension from TaskManager. When Panel closes, it destroys the WebContents triggering WEB_CONTENTS_DISCONNECTED notification. However, when the Panel is closed due to "End Process" from TaskManager window, the notification is triggered by RenderViewGone and the WebContents still exist. TaskManager needs to remove Panel from the resource list in both scenarios. TBR=yoshiki BUG=157365 TEST=TaskManagerBrowserTest.KillPanelExtension Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163895

Patch Set 1 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -1 line)			Patch
	M	chrome/browser/task_manager/task_manager_browsertest.cc	View		1 chunk	+45 lines, -0 lines	0 comments	Download
	M	chrome/browser/task_manager/task_manager_resource_providers.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/11246005/8001

8 years, 2 months ago (2012-10-24 17:56:40 UTC) #2

Change committed as 163895

Expand Messages | Collapse Messages