Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11246003: Remove Profile->GetExtensionProcessManager (Closed)

Created:
8 years, 2 months ago by Miranda Callahan
Modified:
8 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, kkania, Aaron Boodman, robertshield, chromium-apps-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove Profile->GetExtensionProcessManager calls; replace with PKSF calls through the ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces all the deprecated calls that ran directly through the Profile object. BUG=104095 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163846

Patch Set 1 #

Patch Set 2 : remove calls from profile classes #

Patch Set 3 : fix chromeos #

Patch Set 4 : fix lazy apitest #

Total comments: 4

Patch Set 5 : fix extension_crash_recovery_browsertest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -103 lines) Patch
M chrome/browser/automation/automation_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 7 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_handler_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_browsertest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/alert_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_devtools_browsertests.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/gpu_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 2 3 11 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/extensions/lazy_background_task_queue.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/process_management_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Miranda Callahan
Hi, Yoyo -- this is the first set of changes. Looks big, but it's really ...
8 years, 2 months ago (2012-10-22 21:01:52 UTC) #1
Miranda Callahan
On 2012/10/22 21:01:52, Miranda Callahan wrote: > Hi, Yoyo -- this is the first set ...
8 years, 2 months ago (2012-10-22 21:02:31 UTC) #2
Yoyo Zhou
LGTM; please make sure the trybots pass. https://chromiumcodereview.appspot.com/11246003/diff/14047/chrome/browser/extensions/extension_crash_recovery_browsertest.cc File chrome/browser/extensions/extension_crash_recovery_browsertest.cc (right): https://chromiumcodereview.appspot.com/11246003/diff/14047/chrome/browser/extensions/extension_crash_recovery_browsertest.cc#newcode10 chrome/browser/extensions/extension_crash_recovery_browsertest.cc:10: #include "chrome/browser/extensions/extension_service.h" ...
8 years, 2 months ago (2012-10-23 00:20:06 UTC) #3
Miranda Callahan
https://codereview.chromium.org/11246003/diff/14047/chrome/browser/extensions/extension_crash_recovery_browsertest.cc File chrome/browser/extensions/extension_crash_recovery_browsertest.cc (right): https://codereview.chromium.org/11246003/diff/14047/chrome/browser/extensions/extension_crash_recovery_browsertest.cc#newcode10 chrome/browser/extensions/extension_crash_recovery_browsertest.cc:10: #include "chrome/browser/extensions/extension_service.h" On 2012/10/23 00:20:06, Yoyo Zhou wrote: > ...
8 years, 2 months ago (2012-10-23 11:04:43 UTC) #4
Miranda Callahan
OWNERS reviewers: phajdan -- automation, test yurys -- debugger agl -- net yoshiki -- task ...
8 years, 2 months ago (2012-10-23 12:06:10 UTC) #5
agl
net LGTM
8 years, 2 months ago (2012-10-23 13:55:21 UTC) #6
sky
LGTM
8 years, 2 months ago (2012-10-23 16:34:35 UTC) #7
Elliot Glaysher
gtk/profiles lgtm
8 years, 2 months ago (2012-10-23 16:44:31 UTC) #8
Paweł Hajdan Jr.
automation & test: LGTM
8 years, 2 months ago (2012-10-24 01:11:33 UTC) #9
yoshiki
task manager: LGTM
8 years, 2 months ago (2012-10-24 01:54:56 UTC) #10
yurys
debugger LGTM
8 years, 2 months ago (2012-10-24 09:06:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mirandac@chromium.org/11246003/2007
8 years, 2 months ago (2012-10-24 14:11:10 UTC) #12
arv (Not doing code reviews)
webui: LGTM
8 years, 2 months ago (2012-10-24 14:25:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mirandac@chromium.org/11246003/2007
8 years, 2 months ago (2012-10-24 14:43:38 UTC) #14
commit-bot: I haz the power
8 years, 1 month ago (2012-10-24 16:44:10 UTC) #15 
Change committed as 163846

Powered by Google App Engine
This is Rietveld 408576698