GTTF: Fix build with _GLIBCXX_DEBUG

GTTF: Fix build with _GLIBCXX_DEBUG

BUG=65151
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163882

[Paweł Hajdan Jr., 2012-10-24 16:30:22]

Please review:

erg: everything, including chrome/browser/profiles OWNERS
jamesr: webkit OWNERS

[Elliot Glaysher, 2012-10-24 16:39:38]

http://codereview.chromium.org/11238074/diff/1/build/common.gypi
File build/common.gypi (left):

http://codereview.chromium.org/11238074/diff/1/build/common.gypi#oldcode1571
build/common.gypi:1571: 'cflags_cc!': ['-fno-rtti'],
+tzik

I don't understand why this was here in the first place. Is this actually
harmless to pull out? (Can glibcxx_debug work without C++ RTTI data?)

[Paweł Hajdan Jr., 2012-10-24 16:50:16]

http://codereview.chromium.org/11238074/diff/1/build/common.gypi
File build/common.gypi (left):

http://codereview.chromium.org/11238074/diff/1/build/common.gypi#oldcode1571
build/common.gypi:1571: 'cflags_cc!': ['-fno-rtti'],
On 2012/10/24 16:39:39, Elliot Glaysher wrote:
> +tzik
> 
> I don't understand why this was here in the first place. Is this actually
> harmless to pull out? (Can glibcxx_debug work without C++ RTTI data?)

Good question. There was a bug in gcc
(http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40160) that required usage of RTTI
with _GLIBCXX_DEBUG or chrome wouldn't compile. Now we have a more recent gcc in
Ubuntu, and can use _GLIBCXX_DEBUG without RTTI (I've tested that locally and on
trybots).

[Elliot Glaysher, 2012-10-24 17:02:50]

On 2012/10/24 16:50:16, Paweł Hajdan Jr. wrote:
> Good question. There was a bug in gcc
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40160) that required usage of
RTTI
> with _GLIBCXX_DEBUG or chrome wouldn't compile. Now we have a more recent gcc
in
> Ubuntu, and can use _GLIBCXX_DEBUG without RTTI (I've tested that locally and
on
> trybots).

Does that include Lucid?

[Elliot Glaysher, 2012-10-24 17:13:19]

now that you said that the trybots are lucid, lgtm

[jamesr, 2012-10-24 17:15:16]

lgtm

[commit-bot: I haz the power, 2012-10-24 17:26:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11238074/1

[commit-bot: I haz the power, 2012-10-24 19:27:04]

Change committed as 163882