Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3147)

Unified Diff: chrome/browser/extensions/shell_window_registry.cc

Issue 11238055: Re-open DevTools windows for PackagedApps if they are reloaded with DevTools open. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: reviewer comments, use MAYBE_ Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/shell_window_registry.cc
diff --git a/chrome/browser/extensions/shell_window_registry.cc b/chrome/browser/extensions/shell_window_registry.cc
index a25bd3d3a00c4a6e0203ec60875118dcc1e10848..a605efd3de129f9bd88b033047c2633618e835a4 100644
--- a/chrome/browser/extensions/shell_window_registry.cc
+++ b/chrome/browser/extensions/shell_window_registry.cc
@@ -6,12 +6,44 @@
#include "chrome/browser/profiles/profile_dependency_manager.h"
#include "chrome/browser/ui/extensions/shell_window.h"
#include "chrome/common/extensions/extension.h"
+#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
+namespace {
+
+// Create a key that identifies a ShellWindow in a RenderViewHost across App
+// reloads. Current format concatenates the extension ID (fixed length string)
+// a colon separator, and the ShellWindow's |id| (passed to create). If the
+// RenderViewHost is not for a ShellWindow, or if the window was not created
+// with an |id|, return an empty string.
+std::string GetWindowKeyForRenderViewHost(
+ const extensions::ShellWindowRegistry* registry,
+ content::RenderViewHost* render_view_host) {
+ ShellWindow* shell_window =
+ registry->GetShellWindowForRenderViewHost(render_view_host);
+ if (!shell_window)
+ return std::string(); // Not a ShellWindow.
+
+ if (shell_window->window_key().empty())
+ return std::string(); // Not created with an |id| in CreateParams.
+
+ std::string key = shell_window->extension()->id();
+ key += ':';
+ key += shell_window->window_key();
+ return key;
+}
+
+}
+
namespace extensions {
-ShellWindowRegistry::ShellWindowRegistry() {}
+ShellWindowRegistry::ShellWindowRegistry(Profile* profile) {
+ registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED,
+ content::Source<content::BrowserContext>(profile));
+ registrar_.Add(this, content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED,
+ content::Source<content::BrowserContext>(profile));
+}
ShellWindowRegistry::~ShellWindowRegistry() {}
@@ -85,6 +117,33 @@ ShellWindow* ShellWindowRegistry::GetCurrentShellWindowForApp(
return result;
}
+bool ShellWindowRegistry::HadDevToolsAttached(
+ content::RenderViewHost* render_view_host) const {
+ std::string key = GetWindowKeyForRenderViewHost(this, render_view_host);
+ return key.empty() ? false : inspected_windows_.count(key) != 0;
+}
+
+void ShellWindowRegistry::Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) {
+ content::RenderViewHost* render_view_host =
+ content::Details<content::RenderViewHost>(details).ptr();
+ std::string key = GetWindowKeyForRenderViewHost(this, render_view_host);
+ if (key.empty())
+ return;
+
+ switch (type) {
+ case content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED:
+ inspected_windows_.insert(key);
+ break;
+ case content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED:
+ inspected_windows_.erase(key);
+ break;
+ default:
+ NOTREACHED();
+ }
+}
+
///////////////////////////////////////////////////////////////////////////////
// Factory boilerplate
@@ -109,7 +168,7 @@ ShellWindowRegistry::Factory::~Factory() {
ProfileKeyedService* ShellWindowRegistry::Factory::BuildServiceInstanceFor(
Profile* profile) const {
- return new ShellWindowRegistry();
+ return new ShellWindowRegistry(profile);
}
bool ShellWindowRegistry::Factory::ServiceHasOwnInstanceInIncognito() const {
« no previous file with comments | « chrome/browser/extensions/shell_window_registry.h ('k') | chrome/test/data/extensions/platform_apps/minimal_id/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698