Add OnSyncEnabled/OnWriteEnabled notification handling to operation runner

Add OnSyncEnabled/OnWriteEnabled notification handling to operation runner

* Slightly changing ownership relationship: now LocalFileSyncContext owns both SyncableFileOperationRunner and LocalFileSyncStatus (previously SyncContext used to own OperationRunner that owns SyncStatus)
* Adding OnSyncEnabled, OnWriteEnabled notifications to the LocalFileSyncStatus
* Let SyncableFileOperation listen to OnWriteEnabled notification so that it can automatically start write operations (as far as the # of operations is less than the given max)

BUG=148897, 154234
TEST=SyncableFileOperationRunnerTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163584

[kinuko, 2012-10-23 05:22:05]

Split out from http://codereview.chromium.org/11235027/. This one will be easier
to review. PTL thanks

[tzik, 2012-10-23 06:08:20]

lgtm

http://codereview.chromium.org/11238054/diff/5001/webkit/fileapi/syncable/syn...
File webkit/fileapi/syncable/syncable_file_operation_runner.h (right):

http://codereview.chromium.org/11238054/diff/5001/webkit/fileapi/syncable/syn...
webkit/fileapi/syncable/syncable_file_operation_runner.h:79: size_t
num_pending_tasks() const { return pending_tasks_.size(); }
Could you s/size_t/int64/ and add static_cast?

http://codereview.chromium.org/11238054/diff/5001/webkit/fileapi/syncable/syn...
webkit/fileapi/syncable/syncable_file_operation_runner.h:91: const size_t
max_inflight_tasks_;
ditto

[kinuko, 2012-10-23 07:54:02]

Thanks!

http://codereview.chromium.org/11238054/diff/5001/webkit/fileapi/syncable/syn...
File webkit/fileapi/syncable/syncable_file_operation_runner.h (right):

http://codereview.chromium.org/11238054/diff/5001/webkit/fileapi/syncable/syn...
webkit/fileapi/syncable/syncable_file_operation_runner.h:79: size_t
num_pending_tasks() const { return pending_tasks_.size(); }
On 2012/10/23 06:08:20, tzik wrote:
> Could you s/size_t/int64/ and add static_cast?

Done.

http://codereview.chromium.org/11238054/diff/5001/webkit/fileapi/syncable/syn...
webkit/fileapi/syncable/syncable_file_operation_runner.h:91: const size_t
max_inflight_tasks_;
On 2012/10/23 06:08:20, tzik wrote:
> ditto

Done.

[commit-bot: I haz the power, 2012-10-23 08:08:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/11238054/11003

[commit-bot: I haz the power, 2012-10-23 08:32:53]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-23 09:07:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/11238054/11003

[commit-bot: I haz the power, 2012-10-23 09:38:43]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-23 15:07:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/11238054/19

[commit-bot: I haz the power, 2012-10-23 17:10:55]

Change committed as 163584