Issue 11238004: Make the AutocompleteHistoryManager be an implementation detail of AutofillManager.

Issue 11238004: Make the AutocompleteHistoryManager be an implementation detail of AutofillManager. (Closed)

Created:
8 years, 2 months ago by Avi (use Gerrit)

Modified:
8 years, 2 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, dyu1, ajwong+watch_chromium.org, Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make the AutocompleteHistoryManager be an implementation detail of AutofillManager. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163201

Patch Set 2 : AutofillMetricsTest #

Patch Set 4 : rebase, comment #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -47 lines)			Patch
M	chrome/browser/autofill/autocomplete_history_manager.h	View		3 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/autofill/autocomplete_history_manager.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/autofill_external_delegate.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/autofill_external_delegate_unittest.cc	View		2 chunks	+20 lines, -11 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager.h	View	1 2 3	5 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager.cc	View		6 chunks	+18 lines, -5 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager_unittest.cc	View	1 2	5 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/autofill/autofill_metrics_unittest.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.cc	View		3 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM, thanks! https://chromiumcodereview.appspot.com/11238004/diff/9001/chrome/browser/autofill/autofill_manager.h File chrome/browser/autofill/autofill_manager.h (right): https://chromiumcodereview.appspot.com/11238004/diff/9001/chrome/browser/autofill/autofill_manager.h#newcode347 chrome/browser/autofill/autofill_manager.h:347: // Handles form data. nit: Perhaps something ...

8 years, 2 months ago (2012-10-20 06:01:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11238004/20

8 years, 2 months ago (2012-10-20 17:27:52 UTC) #3

Avi (use Gerrit)

https://codereview.chromium.org/11238004/diff/9001/chrome/browser/autofill/autofill_manager.h File chrome/browser/autofill/autofill_manager.h (right): https://codereview.chromium.org/11238004/diff/9001/chrome/browser/autofill/autofill_manager.h#newcode347 chrome/browser/autofill/autofill_manager.h:347: // Handles form data. Absolutely. I was hoping to ...

8 years, 2 months ago (2012-10-20 17:28:11 UTC) #4

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

8 years, 2 months ago (2012-10-20 17:39:40 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11238004/20

8 years, 2 months ago (2012-10-20 19:38:35 UTC) #6

Change committed as 163201

Expand Messages | Collapse Messages