Issue 11237002: Micro-optimizing the json parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11237002: Micro-optimizing the json parser (Closed)

Created:
8 years, 2 months ago by Toon Verwaest

Modified:
8 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Micro-optimizing the json parser Committed: https://code.google.com/p/v8/source/detail?r=12779

Patch Set 2 : Addressed comment #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -56 lines)			Patch
	M	src/json-parser.h	View	1	10 chunks	+43 lines, -56 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nit. https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h File src/json-parser.h (right): https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h#newcode481 src/json-parser.h:481: length); nit: fits on one line

8 years, 2 months ago (2012-10-19 15:36:14 UTC) #2

Toon Verwaest

8 years, 2 months ago (2012-10-19 15:37:40 UTC) #3

addressed comment.

https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h
File src/json-parser.h (right):

https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h#newc...
src/json-parser.h:481: length);
On 2012/10/19 15:36:14, Jakob wrote:
> nit: fits on one line

Done.

Expand Messages | Collapse Messages

Issue 11237002: Micro-optimizing the json parser (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages