Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 11237002: Micro-optimizing the json parser (Closed)

Created:
8 years, 2 months ago by Toon Verwaest
Modified:
8 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Micro-optimizing the json parser Committed: https://code.google.com/p/v8/source/detail?r=12779

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -56 lines) Patch
M src/json-parser.h View 1 10 chunks +43 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL.
8 years, 2 months ago (2012-10-19 15:29:11 UTC) #1
Jakob Kummerow
LGTM with nit. https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h File src/json-parser.h (right): https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h#newcode481 src/json-parser.h:481: length); nit: fits on one line
8 years, 2 months ago (2012-10-19 15:36:14 UTC) #2
Toon Verwaest
8 years, 2 months ago (2012-10-19 15:37:40 UTC) #3
addressed comment.

https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h
File src/json-parser.h (right):

https://chromiumcodereview.appspot.com/11237002/diff/1/src/json-parser.h#newc...
src/json-parser.h:481: length);
On 2012/10/19 15:36:14, Jakob wrote:
> nit: fits on one line

Done.

Powered by Google App Engine
This is Rietveld 408576698