Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 11236066: Adding build target for WebRTC Chrome testing (Closed)

Created:
8 years, 2 months ago by kjellander_chromium
Modified:
8 years, 1 month ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adding build target for WebRTC Chrome testing with peerconnection_server. BUG=None TEST=Compiled the target. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167160

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase + adding frame_analyzer and rgba_to_i420_converter targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/all.gyp View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kjellander_chromium
8 years, 2 months ago (2012-10-23 09:45:59 UTC) #1
kjellander_chromium
Adding phoglund as reviewer instead (as build/OWNERS allows any commiter to approve)
8 years, 1 month ago (2012-11-05 14:40:12 UTC) #2
phoglund_chromium
https://codereview.chromium.org/11236066/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/11236066/diff/1/build/all.gyp#newcode338 build/all.gyp:338: '../third_party/libjingle/libjingle.gyp:peerconnection_server', Looks good in general, but consider putting the ...
8 years, 1 month ago (2012-11-05 14:43:21 UTC) #3
kjellander_chromium
Good idea. I will drop the 'webrtc_test_tools' target in chrome/chrome_tests.gypi in another CL as soon ...
8 years, 1 month ago (2012-11-05 15:29:31 UTC) #4
phoglund_chromium
lgtm
8 years, 1 month ago (2012-11-06 13:36:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/11236066/10001
8 years, 1 month ago (2012-11-12 10:10:19 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-12 11:52:34 UTC) #7
Change committed as 167160

Powered by Google App Engine
This is Rietveld 408576698