Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 11236062: Make chromedriver test suites compatible with python2.7 (Closed)

Created:
8 years, 2 months ago by Yang Gu
Modified:
8 years, 1 month ago
Reviewers:
kkania
CC:
chromium-reviews, yupingx.chen_intel.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make chromedriver test suites compatible with python2.7 BUG = http://code.google.com/p/chromedriver/issues/detail?id=165 TEST = src/chrome/test/webdriver/test/run_webdriver_tests.py src/chrome/test/webdriver/test/run_chromedriver_tests.py Contributed by yupingx.chen@intel.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163791

Patch Set 1 : Make chromedriver test suites compatible with python2.7 and add my name in AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/webdriver/test/py_unittest_util.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Yang Gu
The chromedriver test suites will throw AttributeError under python 2.7, please see http://code.google.com/p/chromedriver/issues/detail?id=165 for details. ...
8 years, 2 months ago (2012-10-23 07:10:54 UTC) #1
kkania
lgtm
8 years, 2 months ago (2012-10-23 15:03:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/11236062/1
8 years, 2 months ago (2012-10-24 01:35:59 UTC) #3
commit-bot: I haz the power
Presubmit check for 11236062-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-24 01:36:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/11236062/6002
8 years, 2 months ago (2012-10-24 02:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/11236062/3003
8 years, 2 months ago (2012-10-24 02:34:24 UTC) #6
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years, 2 months ago (2012-10-24 02:34:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/11236062/3003
8 years, 2 months ago (2012-10-24 02:36:20 UTC) #8
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years, 2 months ago (2012-10-24 02:36:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/11236062/9006
8 years, 2 months ago (2012-10-24 05:39:42 UTC) #10
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 2 months ago (2012-10-24 07:30:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yang.gu@intel.com/11236062/9006
8 years, 2 months ago (2012-10-24 07:45:57 UTC) #12
commit-bot: I haz the power
Change committed as 163791
8 years, 2 months ago (2012-10-24 08:23:17 UTC) #13
kkania
On 2012/10/24 08:23:17, I haz the power (commit-bot) wrote: > Change committed as 163791 Ah, ...
8 years, 1 month ago (2012-10-24 15:02:01 UTC) #14
Yang Gu
8 years, 1 month ago (2012-10-25 01:59:10 UTC) #15
Yes, Intel helped me sign CLA with Google several months ago. I'm not sure how I
can provide some evidence on this. In fact, my account using Intel email address
was activated from then on. 

Regards,
-Yang

> -----Original Message-----
> From: kkania@chromium.org [mailto:kkania@chromium.org]
> Sent: Wednesday, October 24, 2012 11:02 PM
> To: Gu, Yang
> Cc: chromium-reviews@chromium.org; Chen, YupingX
> Subject: Re: Make chromedriver test suites compatible with python2.7 (issue
> 11236062)
> 
> On 2012/10/24 08:23:17, I haz the power (commit-bot) wrote:
> > Change committed as 163791
> 
> Ah, have you signed the CCLA
> http://code.google.com/legal/corporate-cla-v1.0.html here?  You need to do
that
> and email it to cla-submissions@google.com.  Let me know.
> 
> https://chromiumcodereview.appspot.com/11236062/

Powered by Google App Engine
This is Rietveld 408576698