Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 11236018: use "/" instead of path.sep in owners glob check (Closed)

Created:
8 years, 2 months ago by Dirk Pranke
Modified:
8 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

use "/" instead of path.sep in owners glob check R=maruel@chromium.org BUG=157022 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163198

Patch Set 1 #

Total comments: 1

Patch Set 2 : blacklist \\ as well #

Patch Set 3 : fix lint error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M owners.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dirk Pranke
8 years, 2 months ago (2012-10-20 23:04:45 UTC) #1
M-A Ruel
https://codereview.chromium.org/11236018/diff/1/owners.py File owners.py (right): https://codereview.chromium.org/11236018/diff/1/owners.py#newcode227 owners.py:227: if '/' in glob_string: personally, I'd also blacklist '\\' ...
8 years, 2 months ago (2012-10-20 23:05:23 UTC) #2
Dirk Pranke
On 2012/10/20 23:05:23, Marc-Antoine Ruel wrote: > https://codereview.chromium.org/11236018/diff/1/owners.py > File owners.py (right): > > https://codereview.chromium.org/11236018/diff/1/owners.py#newcode227 ...
8 years, 2 months ago (2012-10-20 23:09:28 UTC) #3
Dirk Pranke
On 2012/10/20 23:09:28, Dirk Pranke wrote: > On 2012/10/20 23:05:23, Marc-Antoine Ruel wrote: > > ...
8 years, 2 months ago (2012-10-20 23:09:43 UTC) #4
M-A Ruel
lgtm
8 years, 2 months ago (2012-10-20 23:23:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/11236018/5001
8 years, 2 months ago (2012-10-20 23:36:28 UTC) #6
commit-bot: I haz the power
Presubmit check for 11236018-5001 failed and returned exit status 1. ************* Module owners C0301:229,0: Line ...
8 years, 2 months ago (2012-10-20 23:39:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/11236018/2002
8 years, 2 months ago (2012-10-20 23:45:05 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-20 23:47:43 UTC) #9
Change committed as 163198

Powered by Google App Engine
This is Rietveld 408576698