Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 11236005: Convert all the foo_test_run from using actions to use rules. (Closed)

Created:
8 years, 2 months ago by M-A Ruel
Modified:
8 years, 2 months ago
Reviewers:
csharp
CC:
chromium-reviews, erikwright+watch_chromium.org, Raghu Simha
Visibility:
Public.

Description

Convert all the foo_test_run from using actions to use rules. This removes a lot of the duplication of the exact details about how to run isolate.py exactly.. This will permit inserting arbitrary command line arguments eventually, for --subdir support. TBR=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163144

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Removed pseudo italic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -103 lines) Patch
M base/base.gyp View 1 chunk +3 lines, -21 lines 0 comments Download
A build/isolate.gypi View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +9 lines, -60 lines 0 comments Download
M third_party/cacheinvalidation/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 chunk +3 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
8 years, 2 months ago (2012-10-19 18:06:18 UTC) #1
csharp
https://codereview.chromium.org/11236005/diff/2001/build/isolate.gypi File build/isolate.gypi (right): https://codereview.chromium.org/11236005/diff/2001/build/isolate.gypi#newcode30 build/isolate.gypi:30: # Note: foo_test.isolate is _included and a source file_. ...
8 years, 2 months ago (2012-10-19 18:24:47 UTC) #2
M-A Ruel
https://codereview.chromium.org/11236005/diff/2001/build/isolate.gypi File build/isolate.gypi (right): https://codereview.chromium.org/11236005/diff/2001/build/isolate.gypi#newcode30 build/isolate.gypi:30: # Note: foo_test.isolate is _included and a source file_. ...
8 years, 2 months ago (2012-10-19 18:26:52 UTC) #3
csharp
Ah, I don't think I've seen that geek italics before. LGTM
8 years, 2 months ago (2012-10-19 18:33:05 UTC) #4
M-A Ruel
On 2012/10/19 18:33:05, csharp wrote: > Ah, I don't think I've seen that geek italics ...
8 years, 2 months ago (2012-10-19 18:35:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/11236005/8001
8 years, 2 months ago (2012-10-19 18:35:49 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-19 20:00:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/11236005/8001
8 years, 2 months ago (2012-10-20 00:12:30 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-20 04:16:33 UTC) #9
Change committed as 163144

Powered by Google App Engine
This is Rietveld 408576698