Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 11235072: [Chromoting] Change ScreenRefresh to use 'if' instead of 'DCHECK'. (Closed)

Created:
8 years, 2 months ago by garykac
Modified:
8 years, 2 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Change ScreenRefresh to use 'if' instead of 'DCHECK'. BUG=154716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163727

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M remoting/host/video_frame_capturer_mac.mm View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
garykac
8 years, 2 months ago (2012-10-23 21:14:54 UTC) #1
Jamie
lgtm http://codereview.chromium.org/11235072/diff/1/remoting/host/video_frame_capturer_mac.mm File remoting/host/video_frame_capturer_mac.mm (right): http://codereview.chromium.org/11235072/diff/1/remoting/host/video_frame_capturer_mac.mm#newcode751 remoting/host/video_frame_capturer_mac.mm:751: return; Nit: This file seems to have braces ...
8 years, 2 months ago (2012-10-23 21:19:20 UTC) #2
garykac
http://codereview.chromium.org/11235072/diff/1/remoting/host/video_frame_capturer_mac.mm File remoting/host/video_frame_capturer_mac.mm (right): http://codereview.chromium.org/11235072/diff/1/remoting/host/video_frame_capturer_mac.mm#newcode751 remoting/host/video_frame_capturer_mac.mm:751: return; On 2012/10/23 21:19:20, Jamie wrote: > Nit: This ...
8 years, 2 months ago (2012-10-23 21:34:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/11235072/4001
8 years, 2 months ago (2012-10-23 21:35:02 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-23 23:42:47 UTC) #5
Change committed as 163727

Powered by Google App Engine
This is Rietveld 408576698