Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 11235016: Change the way we generate versions (Closed)

Created:
8 years, 2 months ago by noelallen1
Modified:
8 years, 2 months ago
Reviewers:
sehr, viettrungluu, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Change the way we generate versions. Changes (sehr) Remove hashes used to determine 'unique' versions. Build release lists for versionable nodes Build mapping for any release to first release Added support to treat interface as type Cleanup (sehr) Removed verbose output from pnacl wrapper. Cleanup use of "private" members Add better error recovery on parsing to prevent deadlock. Fix parser tests. To prevent growing this CL, additional cleanup in BUG=157025 PPAPI (brettw) api/private/*.idl + c/private/*.h Fix IDL use of net_address_private prior to definition Date change on ppapi headers to pass presubmit BUG=156719 TEST=idl_parser.py --test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163603

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -130 lines) Patch
M ppapi/api/private/ppb_net_address_private.idl View 1 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/c/private/ppb_net_address_private.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/generators/generator.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/generators/idl_ast.py View 1 2 6 chunks +108 lines, -38 lines 0 comments Download
M ppapi/generators/idl_c_header.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/generators/idl_c_proto.py View 1 2 7 chunks +32 lines, -5 lines 0 comments Download
M ppapi/generators/idl_gen_wrapper.py View 1 4 chunks +8 lines, -4 lines 0 comments Download
M ppapi/generators/idl_namespace.py View 1 2 chunks +17 lines, -15 lines 0 comments Download
M ppapi/generators/idl_node.py View 1 7 chunks +104 lines, -44 lines 0 comments Download
M ppapi/generators/idl_parser.py View 1 12 chunks +86 lines, -10 lines 0 comments Download
M ppapi/generators/idl_propertynode.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/generators/idl_release.py View 1 7 chunks +33 lines, -5 lines 0 comments Download
M ppapi/generators/test_cgen/interface.idl View 1 2 chunks +15 lines, -2 lines 0 comments Download
M ppapi/generators/test_namespace/bar.idl View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/generators/test_namespace/foo.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/generators/test_parser/enum.idl View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
noelallen1
8 years, 2 months ago (2012-10-20 23:09:03 UTC) #1
sehr
Spelling nits only. LGTM otherwise. http://codereview.chromium.org/11235016/diff/13021/ppapi/generators/idl_ast.py File ppapi/generators/idl_ast.py (right): http://codereview.chromium.org/11235016/diff/13021/ppapi/generators/idl_ast.py#newcode113 ppapi/generators/idl_ast.py:113: # IDLFileTypeRessolver one s, ...
8 years, 2 months ago (2012-10-22 18:20:09 UTC) #2
viettrungluu
PPB_Instance_Private 0.1 going from M13 to M14 seems a bit odd to me, but it's ...
8 years, 2 months ago (2012-10-22 20:34:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/11235016/10007
8 years, 2 months ago (2012-10-22 20:42:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/11235016/10007
8 years, 2 months ago (2012-10-23 17:24:37 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-23 18:10:07 UTC) #6
Change committed as 163603

Powered by Google App Engine
This is Rietveld 408576698