Optimize inner-loop in JSON.stringify.

Optimize inner-loop in JSON.stringify.


R=verwaest@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=12798

[Toon Verwaest, 2012-10-23 08:24:34]

first round of comments.

https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h...
src/json-stringifier.h:575: if (NeedsEscaping(c)) {
This seems backwards; shouldn't it use 'JsonQuotes' (why not JsonEscapeSequences
or so) if it needs escaping?

https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h...
src/json-stringifier.h:592: if (current_index_ + (length << 3) < (part_length_ -
2)) {
Please document these magic numbers somehow (either using constants or just
comments).

[Yang, 2012-10-23 08:57:37]

Addressed comments. Please take another look.

https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h...
src/json-stringifier.h:575: if (NeedsEscaping(c)) {
On 2012/10/23 08:24:35, Toon Verwaest wrote:
> This seems backwards; shouldn't it use 'JsonQuotes' (why not
JsonEscapeSequences
> or so) if it needs escaping?

Done.

https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h...
src/json-stringifier.h:592: if (current_index_ + (length << 3) < (part_length_ -
2)) {
On 2012/10/23 08:24:35, Toon Verwaest wrote:
> Please document these magic numbers somehow (either using constants or just
> comments).

Done.

[Toon Verwaest, 2012-10-23 09:01:43]

lgtm