Chromium Code Reviews

Issue 11234031: Optimize inner-loop in JSON.stringify. (Closed)

Created:
8 years, 2 months ago by Yang
Modified:
8 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Optimize inner-loop in JSON.stringify. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12798

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Stats (+67 lines, -44 lines)
M src/json-stringifier.h View 6 chunks +67 lines, -44 lines 0 comments

Messages

Total messages: 4 (0 generated)
Yang
8 years, 2 months ago (2012-10-22 16:43:46 UTC) #1
Toon Verwaest
first round of comments. https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h#newcode575 src/json-stringifier.h:575: if (NeedsEscaping(c)) { This seems ...
8 years, 2 months ago (2012-10-23 08:24:34 UTC) #2
Yang
Addressed comments. Please take another look. https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://chromiumcodereview.appspot.com/11234031/diff/1/src/json-stringifier.h#newcode575 src/json-stringifier.h:575: if (NeedsEscaping(c)) { ...
8 years, 2 months ago (2012-10-23 08:57:37 UTC) #3
Toon Verwaest
8 years, 2 months ago (2012-10-23 09:01:43 UTC) #4
lgtm

Powered by Google App Engine