Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 11233052: Use the current state when resuming. (Closed)

Created:
8 years, 2 months ago by oshima
Modified:
8 years, 2 months ago
Reviewers:
Josh Horwich
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Use the current state when resuming. - When resuming (power_on=1, all_display=1), use the current state to restore display. - Don't turn off the internal display even for mirror mode. chrome never remove the internal display and this was confusing chrome. (I'll do right fix on 25) BUG=chrome-os-partner:14980, 157284 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163716

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M chromeos/display/output_configurator.cc View 1 3 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
8 years, 2 months ago (2012-10-23 01:18:54 UTC) #1
Josh Horwich
Just a clarifying question here http://codereview.chromium.org/11233052/diff/2001/chromeos/display/output_configurator.cc File chromeos/display/output_configurator.cc (right): http://codereview.chromium.org/11233052/diff/2001/chromeos/display/output_configurator.cc#newcode615 chromeos/display/output_configurator.cc:615: connected_output_count_)) { Do we ...
8 years, 2 months ago (2012-10-23 17:12:21 UTC) #2
oshima
On 2012/10/23 17:12:21, Josh Horwich wrote: > Just a clarifying question here > > http://codereview.chromium.org/11233052/diff/2001/chromeos/display/output_configurator.cc ...
8 years, 2 months ago (2012-10-23 18:58:51 UTC) #3
Josh Horwich
lgtm
8 years, 2 months ago (2012-10-23 20:53:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11233052/8001
8 years, 2 months ago (2012-10-23 21:06:38 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-23 23:14:52 UTC) #6
Change committed as 163716

Powered by Google App Engine
This is Rietveld 408576698