Remove GetExtensionEventRouter from Profile.

Remove GetExtensionEventRouter calls and replace with PKSF calls through the ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces all the deprecated calls that ran directly through the Profile object.

BUG= http://code.google.com/p/chromium/issues/detail?id=104095


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164697

[Miranda Callahan, 2012-10-25 14:55:45]

This is the second in a series of refactoring CLs to remove calls to the
ExtensionService from Profile objects (first CL is here:
https://chromiumcodereview.appspot.com/11246003/)

There are many files, but hopefully nothing too big.

Reviewers:
yoz -- main reviewer and extensions.
dmazzoni -- speech/extension_api and accessibility.
kaiwang -- bookmarks.
sky -- test and history.
satish -- speech.

For bookmarks and history, please note that I had to add a dependency in a DEPS
list that had dire warnings. Because the refactoring I'm doing here is removing
a deprecated method and not adding any really new dependencies (there are plenty
of dependencies on extensions code in the DEPS in question already) -- and I'm
actually helping drive the profile dependencies to zero in both cases -- I hope
that this will fly as a temporary measure.

[sky, 2012-10-25 16:17:37]

LGTM

[dmazzoni, 2012-10-25 18:17:20]

lgtm for accessibility and tts

[Yoyo Zhou, 2012-10-25 22:24:47]

LGTM

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
File chrome/browser/bookmarks/DEPS (right):

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
chrome/browser/bookmarks/DEPS:16:
"!chrome/browser/extensions/extension_system.h",
I think this is okay because the bookmarks files that depend on extensions
belong to a glue layer between bookmarks and extensions (which would be outside
of the main bookmarks module). Kai could comment on whether this makes sense for
bookmarks and componentization.

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/ext...
File chrome/browser/extensions/menu_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/ext...
chrome/browser/extensions/menu_manager_unittest.cc:489: class MockTestingProfile
: public TestingProfile {
Since this is no longer interesting, you can replace it with just
TestingProfile.

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/ext...
chrome/browser/extensions/menu_manager_unittest.cc:571: //
DispatchEventToExtension method into event_)args.
spurious

[Miranda Callahan, 2012-10-26 19:23:00]

Thanks, guys! kaiwang and satish, could I get a peek?

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
File chrome/browser/bookmarks/DEPS (right):

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
chrome/browser/bookmarks/DEPS:16:
"!chrome/browser/extensions/extension_system.h",
thanks -- Kai?

On 2012/10/25 22:24:47, Yoyo Zhou wrote:
> I think this is okay because the bookmarks files that depend on extensions
> belong to a glue layer between bookmarks and extensions (which would be
outside
> of the main bookmarks module). Kai could comment on whether this makes sense
for
> bookmarks and componentization.

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/ext...
File chrome/browser/extensions/menu_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/ext...
chrome/browser/extensions/menu_manager_unittest.cc:489: class MockTestingProfile
: public TestingProfile {
On 2012/10/25 22:24:47, Yoyo Zhou wrote:
> Since this is no longer interesting, you can replace it with just
> TestingProfile.

Done.

https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/ext...
chrome/browser/extensions/menu_manager_unittest.cc:571: //
DispatchEventToExtension method into event_)args.
On 2012/10/25 22:24:47, Yoyo Zhou wrote:
> spurious

Done.

[kaiwang, 2012-10-26 20:55:38]

LGTM

[hans, 2012-10-29 13:18:02]

On 2012/10/25 14:55:45, Miranda Callahan wrote:
> satish -- speech.

lgtm for speech.

[tfarina, 2012-10-29 13:44:07]

On Fri, Oct 26, 2012 at 5:23 PM,  <mirandac@chromium.org> wrote:
>
https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
> File chrome/browser/bookmarks/DEPS (right):
>
>
https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
> chrome/browser/bookmarks/DEPS:16:
> "!chrome/browser/extensions/extension_system.h",
> thanks -- Kai?
>
Scott approval is enough for DEPS changes as well, since he is the
OWNER of bookmarks system! :)

-- 
Thiago

[Miranda Callahan, 2012-10-29 14:17:30]

justinlin, I had to make a small change to some code you added last week --
please review.

On 2012/10/29 13:44:07, tfarina wrote:
> On Fri, Oct 26, 2012 at 5:23 PM,  <mailto:mirandac@chromium.org> wrote:
> >
>
https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
> > File chrome/browser/bookmarks/DEPS (right):
> >
> >
>
https://chromiumcodereview.appspot.com/11232066/diff/29002/chrome/browser/boo...
> > chrome/browser/bookmarks/DEPS:16:
> > "!chrome/browser/extensions/extension_system.h",
> > thanks -- Kai?
> >
> Scott approval is enough for DEPS changes as well, since he is the
> OWNER of bookmarks system! :)
> 
> -- 
> Thiago

Yep, I know -- I added kaiwang specifically because he wrote the warnings and
TODO on the DEPS file that forbade additional inclusions, so I wanted to
specifically make him aware of what I was doing.

[commit-bot: I haz the power, 2012-10-29 16:19:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mirandac@chromium.org/11232066/48002

[commit-bot: I haz the power, 2012-10-29 16:19:53]

Failed to apply patch for chrome/browser/profiles/off_the_record_profile_impl.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/profiles/off_the_record_profile_impl.h
  Hunk #1 FAILED at 40.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/profiles/off_the_record_profile_impl.h.rej

Patch:       chrome/browser/profiles/off_the_record_profile_impl.h
Index: chrome/browser/profiles/off_the_record_profile_impl.h
diff --git a/chrome/browser/profiles/off_the_record_profile_impl.h
b/chrome/browser/profiles/off_the_record_profile_impl.h
index
49c871f5de1694d5711601afd8066c749dc8f221..732b881cf33815ba73308b7c5f5344af5f73f7fa
100644
--- a/chrome/browser/profiles/off_the_record_profile_impl.h
+++ b/chrome/browser/profiles/off_the_record_profile_impl.h
@@ -40,7 +40,6 @@ class OffTheRecordProfileImpl : public Profile,
   virtual Profile* GetOriginalProfile() OVERRIDE;
   virtual ExtensionService* GetExtensionService() OVERRIDE;
   virtual extensions::UserScriptMaster* GetUserScriptMaster() OVERRIDE;
-  virtual extensions::EventRouter* GetExtensionEventRouter() OVERRIDE;
   virtual ExtensionSpecialStoragePolicy*
       GetExtensionSpecialStoragePolicy() OVERRIDE;
   virtual GAIAInfoUpdateService* GetGAIAInfoUpdateService() OVERRIDE;

[justinlin, 2012-10-29 16:32:43]

lgtm

[commit-bot: I haz the power, 2012-10-29 16:37:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mirandac@chromium.org/11232066/30008

[commit-bot: I haz the power, 2012-10-29 19:01:49]

Change committed as 164697