Clean up copy&paste in confirmation dialogs for prefs

Clean up copy&paste in confirmation dialogs for prefs

This CL consolidates the three implementations of virtually identical
confirmation dialogs for prefs into a single class. The new code has
the further advantage that the confirmation dialogs no longer know about
and manipulate any input elements directly but instead, use the dialog
pref system to commit or roll back changes when they are confirmed or
cancelled.

BUG=157319
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163874

[bartfab (slow), 2012-10-23 10:04:26]

Hi James, this CL is motivated by Joao's comment in CL 11232046 that a clean-up
of some existing copy & paste would be useful. Could you have a look?

Dominic, I added you as a reviewer since this CL touches DNT. There should be no
functional changes with this CL but I want to make sure you are OK with it.

[James Hawkins, 2012-10-24 00:54:17]

LGTM with optional nit.

https://codereview.chromium.org/11232059/diff/11/chrome/browser/resources/opt...
File chrome/browser/resources/options/confirm_dialog.js (right):

https://codereview.chromium.org/11232059/diff/11/chrome/browser/resources/opt...
chrome/browser/resources/options/confirm_dialog.js:53: if (event.value.value &&
!this.confirmed_)
Optional nit: For readability, I'd insert a blank line above to separate from
previous block.

[bartfab (slow), 2012-10-24 13:51:45]

https://chromiumcodereview.appspot.com/11232059/diff/11/chrome/browser/resour...
File chrome/browser/resources/options/confirm_dialog.js (right):

https://chromiumcodereview.appspot.com/11232059/diff/11/chrome/browser/resour...
chrome/browser/resources/options/confirm_dialog.js:53: if (event.value.value &&
!this.confirmed_)
On 2012/10/24 00:54:17, James Hawkins wrote:
> Optional nit: For readability, I'd insert a blank line above to separate from
> previous block.

Done.

[commit-bot: I haz the power, 2012-10-24 13:52:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/11232059/15001

[commit-bot: I haz the power, 2012-10-24 16:21:59]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-10-24 17:45:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/11232059/15001

[commit-bot: I haz the power, 2012-10-24 18:38:21]

Change committed as 163874