Issue 11232058: Fix Windows build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11232058: Fix Windows build. (Closed)

Created:
8 years, 2 months ago by Yang

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Windows build. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12799

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/json-stringifier.h	View		1 chunk	+5 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a comment). https://chromiumcodereview.appspot.com/11232058/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://chromiumcodereview.appspot.com/11232058/diff/1/src/json-stringifier.h#newcode576 src/json-stringifier.h:576: ASSERT(sizeof(*dest) >= sizeof(*src)); Could we ...

8 years, 2 months ago (2012-10-23 09:36:07 UTC) #2

Yang

8 years, 2 months ago (2012-10-23 09:39:35 UTC) #3

https://chromiumcodereview.appspot.com/11232058/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):

https://chromiumcodereview.appspot.com/11232058/diff/1/src/json-stringifier.h...
src/json-stringifier.h:576: ASSERT(sizeof(*dest) >= sizeof(*src));
On 2012/10/23 09:36:07, Michael Starzinger wrote:
> Could we turn that into a STATIC_ASSERT or does sizeof() not work for
> STATIC_ASSERTs?

As discussed offline, the <uc16, char> version is compiled, but must not be
called (the compiler doesn't understand the logic behind this, so it compiles
all <{char,uc16}, {char,uc16}> versions. So a STATIC_ASSERT would fail here.

Expand Messages | Collapse Messages