Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2431)

Unified Diff: cc/single_thread_proxy.h

Issue 11232051: Remove static thread pointers from CC (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Apply code review comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scrollbar_layer_unittest.cc ('k') | cc/single_thread_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/single_thread_proxy.h
diff --git a/cc/single_thread_proxy.h b/cc/single_thread_proxy.h
index db73ee4f2adca79ef31212ef8bba4a98fe9b3a64..d41955a4c977c6d044c157ef89488937690eb692 100644
--- a/cc/single_thread_proxy.h
+++ b/cc/single_thread_proxy.h
@@ -91,42 +91,58 @@ private:
// code is running on the impl thread to satisfy assertion checks.
class DebugScopedSetImplThread {
public:
- DebugScopedSetImplThread()
+ explicit DebugScopedSetImplThread(Proxy* proxy)
+ : m_proxy(proxy)
{
#ifndef NDEBUG
- Proxy::setCurrentThreadIsImplThread(true);
+ m_previousValue = m_proxy->m_implThreadIsOverridden;
+ m_proxy->setCurrentThreadIsImplThread(true);
#endif
}
~DebugScopedSetImplThread()
{
#ifndef NDEBUG
- Proxy::setCurrentThreadIsImplThread(false);
+ m_proxy->setCurrentThreadIsImplThread(m_previousValue);
#endif
}
+private:
+ bool m_previousValue;
+ Proxy* m_proxy;
};
// For use in the single-threaded case. In debug builds, it pretends that the
// code is running on the main thread to satisfy assertion checks.
class DebugScopedSetMainThread {
public:
- DebugScopedSetMainThread()
+ explicit DebugScopedSetMainThread(Proxy* proxy)
+ : m_proxy(proxy)
{
#ifndef NDEBUG
- Proxy::setCurrentThreadIsImplThread(false);
+ m_previousValue = m_proxy->m_implThreadIsOverridden;
+ m_proxy->setCurrentThreadIsImplThread(false);
#endif
}
~DebugScopedSetMainThread()
{
#ifndef NDEBUG
- Proxy::setCurrentThreadIsImplThread(true);
+ m_proxy->setCurrentThreadIsImplThread(m_previousValue);
#endif
}
+private:
+ bool m_previousValue;
+ Proxy* m_proxy;
};
// For use in the single-threaded case. In debug builds, it pretends that the
// code is running on the impl thread and that the main thread is blocked to
// satisfy assertion checks
class DebugScopedSetImplThreadAndMainThreadBlocked {
+public:
+ explicit DebugScopedSetImplThreadAndMainThreadBlocked(Proxy* proxy)
+ : m_implThread(proxy)
+ , m_mainThreadBlocked(proxy)
+ {
+ }
private:
DebugScopedSetImplThread m_implThread;
DebugScopedSetMainThreadBlocked m_mainThreadBlocked;
« no previous file with comments | « cc/scrollbar_layer_unittest.cc ('k') | cc/single_thread_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698